Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require JDK 17 for build #327

Merged
merged 3 commits into from
Dec 10, 2023
Merged

Require JDK 17 for build #327

merged 3 commits into from
Dec 10, 2023

Conversation

slawekjaranowski
Copy link
Member

  • reuse javaVersion property from parent
  • property maven.compiler.release is set by parent for JDK 11+
  • reuse checking of bytecode version from parent

@slawekjaranowski
Copy link
Member Author

Required for #326 - newer version of eclipse compiler

@slawekjaranowski
Copy link
Member Author

We need a newer Maven 3.9.6+ due to old sisu without support for JDK 11+

@slawekjaranowski slawekjaranowski marked this pull request as draft December 9, 2023 16:55
@slachiewicz
Copy link
Member

To build, test the eclipse compiler component. But later all other compilers can be used normally.
Maybe just add note to release notes?

@slawekjaranowski
Require JDK 17 for build
45ea5bc 
- reuse javaVersion property from parent
- property maven.compiler.release is set by parent for JDK 11+
- reuse checking of bytecode version from parent
@slawekjaranowski
Copy link
Member Author

To build, test the eclipse compiler component. But later all other compilers can be used normally. Maybe just add note to release notes?

Good idea 👍

@slawekjaranowski slawekjaranowski marked this pull request as ready for review December 10, 2023 08:34
@slawekjaranowski slawekjaranowski mentioned this pull request Dec 10, 2023
Merged
@slawekjaranowski slawekjaranowski merged commit 750d934 into master Dec 10, 2023
36 checks passed
@slawekjaranowski slawekjaranowski deleted the jdk-17 branch December 10, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzygielo pzygielo pzygielo left review comments

@slachiewicz slachiewicz slachiewicz approved these changes

@olamy olamy Awaiting requested review from olamy

@gnodet gnodet Awaiting requested review from gnodet

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slawekjaranowski @slachiewicz @pzygielo