Support the Info-ZIP Unicode Path Extra Field. #41
Conversation
…ting an archive using an encoding different from UTF-8 instead of only when a name is not encodeable. Additionally support that extra field when unarchiving. This closes #39
| return defaultManifest; | ||
| } | ||
| catch ( final IOException e ) | ||
| { |
There was a problem hiding this comment.
What purpose serves this try catch block? No one throws an IOException. Not the PropertyUtils.
There was a problem hiding this comment.
I consider the swallow here was intentional. The local was actually borrowed from other spots where the version is omitted of the pom.properties could not be read. This needs a rewrite now.
There was a problem hiding this comment.
Am 05/27/16 um 00:38 schrieb Michael Osipov:
In
src/main/java/org/codehaus/plexus/archiver/jar/JdkManifestFactory.java
#41 (comment):
return defaultManifest;defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
return defaultManifest;}catch ( final IOException e ){What purpose serves this try catch block? No one throws an
|IOException|. Not the |PropertyUtils|.
PropertyUtils started throwing the exception with the latest patch
release of 'plexus-utils'.
There was a problem hiding this comment.
Am 05/27/16 um 00:57 schrieb Michael Osipov:
In
src/main/java/org/codehaus/plexus/archiver/jar/JdkManifestFactory.java
#41 (comment):
return defaultManifest;defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
return defaultManifest;}catch ( final IOException e ){I consider the swallow here
codehaus-plexus/plexus-utils@ba1c194
was intentional. The local was actually borrowed from other spots where
the version is omitted of the |pom.properties| could not be read.
Just restored that behaviour. I even considered throwing an
AssertionError if the properties cannot be read. Omitting the version
shouldn't be an issue, of course.
There was a problem hiding this comment.
There was a problem hiding this comment.
Am 2016-05-27 um 02:51 schrieb Christian Schulte:
return defaultManifest;defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
return defaultManifest;}catch ( final IOException e ){Am 05/27/16 um 00:57 schrieb Michael Osipov:
In
src/main/java/org/codehaus/plexus/archiver/jar/JdkManifestFactory.java
#41 (comment):
return defaultManifest;defaultManifest.getMainAttributes().putValue( "Created-By", createdBy );
return defaultManifest;}catch ( final IOException e ){I consider the swallow here
codehaus-plexus/plexus-utils@ba1c194
was intentional. The local was actually borrowed from other spots where
the version is omitted of the |pom.properties| could not be read.Just restored that behaviour. I even considered throwing an
AssertionError if the properties cannot be read. Omitting the version
I am not convinced that AssertionError is the right thing because
Errors are reverved for the VM. Please search for pom.properties in
maven-core (DefaultRepositorySystemSessionFactory and
DefaultRuntimeInformation). You will see the basic ida it was taken from.
No description provided.