Tuning2 #19
Merged
Tuning2 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
top-on
approved these changes
Sep 26, 2020
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
I would suggest to save us the indentation here, and integrate the sleep within the loop.
There was a problem hiding this comment.
Maybe add the location to the data? The other teams, also do this. Just to be consistent.
"longitude": "51.962077", "latitude": "7.628095"
There was a problem hiding this comment.
Still undecided if that makes sense for a static location, as that info is available for the device already https://counting-backend.codeformuenster.org/devices/south_street_cityhall
There was a problem hiding this comment.
I suppose oskar knows what frontend needs
There was a problem hiding this comment.
I would keep sleep outside because it feels very much like a side effect to me ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
05_count_to_api.py starten und alle 10 Sekunden wird eine Bild ausgewertet und an die API geschickt.