Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1256-update-width-of-form-question-spacing-title-to-be-full-width #5728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DrewProebstel
Copy link
Contributor

@DrewProebstel DrewProebstel commented Mar 11, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • adds a styling to get rid of the width limiting

How to test?

  • Go through the flow and look at all the listed pages with the issue.

Risk Assessment

  • Adds a permament syling. Which does affect the layout of the pages. I looked through other pages that use this and did not see any problems.
  • It is worthing noting that the use of the form-card class seems totally random and not necessary. A large spike to see why we are using it might be beneficial.

Screenshots (for visual changes)

  • After
Screenshot 2025-03-11 at 4 05 45 PM

Screenshot 2025-03-11 at 4 11 18 PM

Copy link

Heroku app: https://gyr-review-app-5728-f14b28b20f6d.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5728 (optionally add --tail)

@DrewProebstel DrewProebstel changed the title adds a new style to form card FYST-1256-update-width-of-form-question-spacing-title-to-be-full-width Mar 11, 2025
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide a list of pages that could potentially be affected by this change for QA folks (in the jira ticket or on the description)? If too many, maybe a sample across the site would be helpful (I'd ignore all ctc pages)

Another thing I thought of -- if we want to limit the impact of this change, maybe this specific styling should be moved into _state-file.scss so the QA doesn't have to reach into GYR -- there's .form-card styling specific for state file there as well, so we can move this block into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants