Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GYR1-698 Team Assignment module display #5722

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GYR1-698 Team Assignment module display #5722

wants to merge 2 commits into from

Conversation

tahsinaislam
Copy link
Contributor

@tahsinaislam tahsinaislam commented Mar 11, 2025 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Combined methods for the teams modules presenter so the pagination and users shown are consistent
  • Updated query for ordering users to no exclude users if they have a client/tax return from a prior year but instead count that older tax return as zero

How to test?

  • Updated presenter tests for the teams module in the dashboard

Screenshots (for visual changes)

  • Before
  • After

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5722-9d3b5662380e.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5722 (optionally add --tail)

@tahsinaislam @anisharamnani
Fix query
4b7fc95 
Co-authored-by: Anisha Ramnani <[email protected]>
@tahsinaislam tahsinaislam marked this pull request as ready for review March 11, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tahsinaislam