NJ 235 - fix calculator negative value bug #5706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5706-f17cbf0d28b0.herokuapp.com/ |
aloverso
approved these changes
Mar 7, 2025
Comment on lines
735
to
741
| context 'when 28c is larger than 29' do | ||
| it 'sets line 29 to zero' do | ||
| allow(instance).to receive(:calculate_line_15).and_return 1_000 | ||
| allow(instance).to receive(:calculate_line_16a).and_return 1_000 | ||
| allow(instance).to receive(:calculate_line_28c).and_return 2_001 | ||
| instance.calculate | ||
| expect(instance.lines[:NJ1040_LINE_29].value).to eq(0) |
There was a problem hiding this comment.
[pebble] I think the test title is misleading here? It should be "when 28c is greater than line 27" (from looking at the code) right?
Additionally, if that is the case, I'd suggest/prefer to see the test simplified by just mocking Line 27 and Line 28c rather than lines 15 and 16a, which seems more complicated and harder to read/parse.
There was a problem hiding this comment.
That makes sense. The logic for line 27 has also changed in the meantime so this makes it more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)
Before
After
