[FYST-1359] Add Names and SSN to ID39 PDF #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Drew Proebstel <[email protected]>
anisharamnani
changed the title
|
Heroku app: https://gyr-review-app-5701-316f4bd81988.herokuapp.com/ |
arinchoi03
reviewed
Mar 7, 2025
app/lib/pdf_filler/id39r_pdf.rb
Outdated
| @@ -40,6 +43,18 @@ def hash_for_pdf | |||
| answers | |||
| end | |||
|
|
|||
| def formatted_display_name | |||
| if @intake.filing_status_mfj? | |||
| if @intake.primary.last_name == @intake.spouse.last_name | |||
There was a problem hiding this comment.
[super dust] i dont think this will be a likely scenario, but what if for some reason they had different capitalizations? Should we downcase & match? Probably doesn't matter much at the end of the day, so feel free to ignore
There was a problem hiding this comment.
🤔 it’s not a bad idea, i pushed up a fix for this!
…39-r-missing-filer-name-and-ssn-at-top-of-pages
…39-r-missing-filer-name-and-ssn-at-top-of-pages
…39-r-missing-filer-name-and-ssn-at-top-of-pages
anisharamnani
deleted the
FYST-1359-idaho-form-39-r-missing-filer-name-and-ssn-at-top-of-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
Added Names & SSN to ID39.
How to test?
id39r_pdf_spec.rbScreenshots (for visual changes)