Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1192 Remove button height #5695

Conversation

jenny-heath
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Spanish text overflowed the text/email notification buttons (and also maybe on the data transfer button?)
  • Story didn't specify how to fix this so I just removed the button height. As far as I can tell the buttons all look the same except the ones with overflowing text

How to test?

  • Visually? Might be good to do a sweep of the website to make sure the buttons don't look terrible

Screenshots (for visual changes)

  • Before
image image
  • After
image image

Copy link

github-actions bot commented Mar 6, 2025

Heroku app: https://gyr-review-app-5695-c9e3eb519dff.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5695 (optionally add --tail)

Copy link
Contributor

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ if it’s okay with the design team, then it’s okay with me!

@amurthy2
Copy link

amurthy2 commented Mar 7, 2025

@jenny-heath this looks good to me!

@mrotondo mrotondo merged commit 06d886b into main Mar 10, 2025
7 checks passed
@mrotondo mrotondo deleted the FYST-1192-all-states-text-email-me-a-code-text-exceeds-box-size-with-spanish-text-set branch March 10, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants