-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FYST-1900] Make MD retirement subtraction card consistent with other states' #5691
[FYST-1900] Make MD retirement subtraction card consistent with other states' #5691
Conversation
…r by utilizing eligible_109rs
…e 1099r is when taxable_income exists
…t-1099rs-with-taxable-amt
Heroku app: https://gyr-review-app-5691-6c3432eecf93.herokuapp.com/ |
97c8c9a
to
385c9a1
Compare
385c9a1
to
a544708
Compare
<div class="spacing-below-5"> | ||
<h2 class="text--body text--bold spacing-below-15"><%=t(".retirement_income_deductions") %></h2> | ||
|
||
<% current_intake.eligible_1099rs.each_with_index do |state_file1099_r, index| %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that we're changing to eligible_1099rs
instead of state_file1099_rs
here -- could have problems navigating back to a specific 1099R unless we have the same indices as we are using in the subtraction controllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact, we do have a problem. I used frank rollover & tried to navigate to the 2nd retirement deduction shown -- it takes me to oops page (on demo; fixed on this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ Thanks Arin for taking on this work!
…rement-subtractions-card-on-final-review-to-be-consistent-with-az-md-nc
…rement-subtractions-card-on-final-review-to-be-consistent-with-az-md-nc
Followup to #5680; noticed that all states now use the partial in the review_header but only MD does not
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
eligible_1099rs
: previously we were showing this card if any 1099rs exist, and then only showing the relevant sub-elements if followup existed (which could only exist if the 1099r was qualified) which is a bit less straightforward.md_review
b/c it needs to show if 1099Rs exist at all (at this point anyway, that's the logic); there is a followup ticket to refactor this to show if it matches theinclude
logic on MD502R; Anyways, disability needs to be shown if 502R exists at all, soeligible_1099rs
logic does not factor into showing disability-related information on the final review. I can move the whole section into the partial, if desired.shared
folder, i think they should all move back into the#{stsate_code}_review
folders as specific partials. However, that'll involve me moving around more copy & not sure if i want to make Aaron/September do more testing for all states 😭How to test?
Screenshots (for visual changes)