GYR1-690 allow site coordinators to edit site coordinator and team member accounts #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5688-41b74de38d4e.herokuapp.com/ |
embarnard
approved these changes
Mar 6, 2025
app/lib/ability.rb
Outdated
| @@ -189,6 +188,9 @@ def initialize(user) | |||
| end | |||
|
|
|||
| if user.site_coordinator? | |||
| can :manage, User, id: User.where(role: SiteCoordinatorRole.assignable_to_sites(user.role.sites)).pluck(:id) | |||
There was a problem hiding this comment.
I would just check with product that we want to include all these actions, for example I'm not sure if we want to allow them to destroy users (we use suspend/unsuspend instead) so something like might be more accurate:
Suggested change
| can :manage, User, id: User.where(role: SiteCoordinatorRole.assignable_to_sites(user.role.sites)).pluck(:id) | |
| can [:update, :create, :update, :unsuspend, :suspend (and any other custom actions)], User, id: User.where(role: SiteCoordinatorRole.assignable_to_sites(user.role.sites)).pluck(:id) |
app/lib/ability.rb
Outdated
| @@ -189,6 +188,9 @@ def initialize(user) | |||
| end | |||
|
|
|||
| if user.site_coordinator? | |||
| can :manage, User, id: User.where(role: SiteCoordinatorRole.assignable_to_sites(user.role.sites)).pluck(:id) | |||
| can :manage, User, id: User.where(role: TeamMemberRole.assignable_to_sites(user.role.sites)).pluck(:id) | |||
There was a problem hiding this comment.
I guess instead of including all those custom actions you could also just add a cannot after the lines like for example
Suggested change
| can :manage, User, id: User.where(role: TeamMemberRole.assignable_to_sites(user.role.sites)).pluck(:id) | |
| can :manage, User, id: User.where(role: TeamMemberRole.assignable_to_sites(user.role.sites)).pluck(:id) | |
| cannot :destroy, User |
Co-authored-by: Drew Proebstel <[email protected]>
| @@ -189,6 +188,9 @@ def initialize(user) | |||
| end | |||
|
|
|||
| if user.site_coordinator? | |||
| can [:suspend, :unsuspend, :update, :unlock, :resend_invitation], User, id: User.where(role: SiteCoordinatorRole.assignable_to_sites(user.role.sites)).pluck(:id) | |||
There was a problem hiding this comment.
Thanks @embarnard for flagging the actions! These are the updated ones.
Co-authored-by: Drew Proebstel <[email protected]>
This reverts commit 67d7450.
app/lib/pdf_filler/id39r_pdf.rb
Outdated
| @@ -8,7 +8,6 @@ def source_pdf_name | |||
|
|
|||
| def initialize(submission) | |||
| @submission = submission | |||
| @intake = submission.data_source | |||
There was a problem hiding this comment.
🙈 i was switching between branches and did the wrong thing
…oordinators-to-edit-site-coordinator-and-team-member-accounts
anisharamnani
deleted the
GYR1-690-allow-site-coordinators-to-edit-site-coordinator-and-team-member-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
accessible_vita_partners) that wasn't being used in the relevant part of the ability file so we replaced the mocking with just setting up the actual db associationsHow to test?
Screenshots (for visual changes)