FYST-1081 MD Populate exception code for resubmission #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5687-f280bac51570.herokuapp.com/ |
arinchoi03
reviewed
Mar 6, 2025
arinchoi03
approved these changes
Mar 6, 2025
| @@ -38,7 +38,7 @@ def hash_for_pdf | |||
|
|
|||
| 'Maryland Physical Address Line 1 Street No and Street Name No PO Box': @xml_document.at('MarylandAddress AddressLine1Txt')&.text, | |||
| 'Maryland Physical Address Line 2 Apt No Suite No Floor No No PO Box': @xml_document.at('MarylandAddress AddressLine2Txt')&.text, | |||
| 'City': @xml_document.at('MarylandAddress CityNm')&.text, | |||
| City: @xml_document.at('MarylandAddress CityNm')&.text, | |||
There was a problem hiding this comment.
why do you remove the quotes from ‘City’ here?
There was a problem hiding this comment.
hmm, maybe the symbol is enough and it doesn’t matter because the same is happening below as well.
There was a problem hiding this comment.
i'm assuming this is a rubymine suggestion -- we don't need quotes around single-word strings (and I guess something like primary_pension further down is also considered to be a single word)
anisharamnani
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
I just have a clarifying question, otherwise this looks good! Thanks @tahsinaislam!
tahsinaislam
deleted the
FYST-1081-md-populate-exception-code-247-for-resubmissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-1081
Is PM acceptance required? (delete one)
What was done?
How to test?
Screenshots (for visual changes)