[FYST-1868] ID refactor logic #5665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w spouse-specific screen if only spouse 62-65
…le_income factory for 1099Rs
…retirement-deduction-logic
…r by utilizing eligible_109rs
…e eligible_income factory for 1099Rs" This reverts commit 5e3dc55.
…nto FYST-1882-id-update-idaho-retirement-deduction-logic-refactor
…le_income factory for 1099Rs
arinchoi03
changed the title
|
Heroku app: https://gyr-review-app-5665-76883435d8a1.herokuapp.com/ |
…retirement-deduction-logic
…nto FYST-1882-id-update-idaho-retirement-deduction-logic-refactor
Base automatically changed from
FYST-1882-id-update-idaho-retirement-deduction-logic
to
main
March 3, 2025 22:37
…retirement-deduction-logic-refactor
arinchoi03
commented
Mar 4, 2025
| @@ -85,7 +85,7 @@ def calculate_sec_b_line_8d | |||
| end | |||
|
|
|||
| def calculate_sec_b_line_8e | |||
| @intake.state_file1099_rs.sum do |form1099r| | |||
| @intake.eligible_1099rs.sum do |form1099r| | |||
| if form1099r.state_specific_followup&.eligible_income_source_yes? && form1099r.taxable_amount.present? | |||
There was a problem hiding this comment.
presumably with this refactor, taxable_amount will be always present already
…e 1099r is when taxable_income exists
arinchoi03
changed the title
arinchoi03
commented
Mar 4, 2025
| @@ -313,4 +313,15 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe "#eligible_1099rs" do | |||
| %w[az md nc nj].each do |state_code| | |||
There was a problem hiding this comment.
although nj is not using this method, I wanted to make sure it was documented that they will have it
arinchoi03
changed the title
|
closing this, in favor of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
eligible_1099rsincome for ID39R calculationsshowretirement subtractions controllers for all states ifeligible_1099rsexist for the intake instead of if any 1099rs are present. notably for nc currently, there is noeligible_1099rsmethod (it uses the base method, which looks at all 1099rs), so the logic should still be the same.eligible_1099rsmethod in the intake as well.How to test?
disabledto make the 1099R income eligible for id intakes, maybe this was a bad idea?