FYST-1880 Add recipients address to 1099R #5663
Conversation
|
Heroku app: https://gyr-review-app-5663-5c6c4cc7356a.herokuapp.com/ |
| @@ -23,6 +23,15 @@ def document | |||
| xml.PayerEIN form1099r.payer_identification_number | |||
| xml.RecipientSSN sanitize_for_xml(form1099r.recipient_ssn) if form1099r.recipient_ssn.present? | |||
| xml.RecipientNm sanitize_for_xml(form1099r.recipient_name) if form1099r.recipient_name.present? | |||
| if form1099r.recipient_address_line1.present? | |||
| xml.RecipientUSAddress do | |||
| xml.AddressLine1Txt sanitize_for_xml(form1099r.recipient_address_line1) if form1099r.recipient_address_line1.present? | |||
There was a problem hiding this comment.
this .present? check seems redundant b/c it's already on line 26
There was a problem hiding this comment.
ohh i didn't think of that! i added line 26 after
| @@ -23,6 +23,15 @@ def document | |||
| xml.PayerEIN form1099r.payer_identification_number | |||
| xml.RecipientSSN sanitize_for_xml(form1099r.recipient_ssn) if form1099r.recipient_ssn.present? | |||
| xml.RecipientNm sanitize_for_xml(form1099r.recipient_name) if form1099r.recipient_name.present? | |||
| if form1099r.recipient_address_line1.present? | |||
There was a problem hiding this comment.
I wonder about this check -- is it possible that line 1 will be empty but rest of the address present?
Do we only want to pass on the info if the line 1 is present?
There was a problem hiding this comment.
yeah i did realize this felt like a shortcut when i did it. i feel like you can't have an address without line 1? because then it's just a city and a zip code. but we could ask to be safe!
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
state_file1099_rHow to test?
Screenshots (for visual changes)