Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1866-nc-correct-retirement-subtraction-card-text-on-final-review-screen #5648

Conversation

DrewProebstel
Copy link
Contributor

@DrewProebstel DrewProebstel commented Feb 26, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!
    Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Removes an unnecessary if statement that was adding "none apply" when "Retirement benefits as part of the Bailey Settlement" was already shown.

How to test?

  • Follow recreation steps in the Jira ticket.

Screenshots (for visual changes)

  • Before
Screenshot 2025-02-26 at 1 49 41 PM
  • After
Screenshot 2025-02-26 at 1 48 17 PM

Copy link

Heroku app: https://gyr-review-app-5648-fb6f9733d31c.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5648 (optionally add --tail)

@DrewProebstel DrewProebstel changed the title remove unneeded FYST-1866-nc-correct-retirement-subtraction-card-text-on-final-review-screen Feb 26, 2025
@DrewProebstel DrewProebstel merged commit 051e91c into main Feb 27, 2025
7 checks passed
@DrewProebstel DrewProebstel deleted the FYST-1866-nc-correct-retirement-subtraction-card-text-on-final-review-screen branch February 27, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant