FYST-397 ensure that waiting to load data always proceeds correctly #5615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Arin Choi <[email protected]>
Co-authored-by: Jenny Heath <[email protected]>
…waiting-to-load-data-always-proceeds-correctly Co-authored-by: Jenny Heath <[email protected]>
|
Heroku app: https://gyr-review-app-5615-e3b7a981d4f8.herokuapp.com/ |
arinchoi03
approved these changes
Feb 20, 2025
|
@arinchoi03 I believe this is to check if the client already has |
anisharamnani
deleted the
FYST-397-ensure-that-waiting-to-load-data-always-proceeds-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-397
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
This is plagiarism from Mike's original description:
Calls stream_for intake before broadcast_job_complete(intake). broadcast_to(intake, ...) is called by broadcast_job_complete(intake), but won’t do anything until stream_for is called. This should marginally speed up the data transfer page
How to test?
We've written some tests. They are as good as they can get & don't actually test the problem. But, the action cable testing documentation is very limited.