Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GYR] Reorder life situations checkboxes and remove must select one logic #5595

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Feb 15, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • reordered checkboxes on GYR's life situation page and remove logic to makes them select an option on that page

How to test?

  • use heroku, go to the life situations page in the flow or through the flow explorer

Screenshots (for visual changes)

  • After
    primary:
Screenshot 2025-02-14 at 7 21 10 PM

spouse:
Screenshot 2025-02-25 at 12 46 22 PM

dependents:
Screenshot 2025-02-25 at 12 45 41 PM

Copy link

Heroku app: https://gyr-review-app-5595-a8a0da5d26b9.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5595 (optionally add --tail)

Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

…kboxes-on-life-situations-controller-spouse-life-situations-controller-to-match-ty-2024-pdf-allow-skip
…kboxes-on-life-situations-controller-spouse-life-situations-controller-to-match-ty-2024-pdf-allow-skip
@embarnard embarnard merged commit d1b1a11 into main Feb 28, 2025
7 checks passed
@embarnard embarnard deleted the GYR1-672-reorder-checkboxes-on-life-situations-controller-spouse-life-situations-controller-to-match-ty-2024-pdf-allow-skip branch February 28, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants