[GYR] Fix a reference in the prod creds; we were trying to use a demo number when connecting calls instead of the more strongly verified prod number #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when connecting calls instead of the more strongly verified prod number
|
Heroku app: https://gyr-review-app-5553-d7e32adfb24c.herokuapp.com/ |
embarnard
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
n/a
Is PM acceptance required? (delete one)
No - merge after code review approval
What was done?
Replace an incorrect value in the prod creds related to how GYR connects phone calls.
How to test?
Probably best way to test would be to pull the branch locally and starting a console as prod environment. The reference fetched for connecting calls should be the known-good GYR prod number (650) rather than the testing/demo number (415)