Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FYST-1628] Adjust faq page spacing #5543

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[FYST-1628] Adjust faq page spacing #5543

merged 2 commits into from
Feb 19, 2025

Conversation

squanto
Copy link
Contributor

@squanto squanto commented Feb 7, 2025

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-1628

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main
add top margin to faq index + show pages

Copy link

github-actions bot commented Feb 7, 2025

Heroku app: https://gyr-review-app-5543-f33bcb2c5f8d.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5543 (optionally add --tail)

mpidcock
mpidcock previously approved these changes Feb 12, 2025
@mpidcock mpidcock dismissed their stale review February 12, 2025 00:10

The story asks to change the login page too, not just the faq 🙏

Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
@squanto squanto force-pushed the FYST-1628-all-states-faq branch from 2eddb11 to c40f1b7 Compare February 13, 2025 16:22
@squanto squanto requested a review from mpidcock February 13, 2025 16:22
Copy link
Member

@mpidcock mpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@squanto squanto merged commit 4c4e3e1 into main Feb 19, 2025
7 checks passed
@squanto squanto deleted the FYST-1628-all-states-faq branch February 19, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants