Only show the main error instead of the latest created efile error

[arinchoi03]

Link to pivotal/JIRA issue

• https://codeforamerica.atlassian.net/browse/FYST-1761

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• Hackiest, narrowest solution possible to unblock clients, so they'll see the main error they need to correct which should help resolve the related errors.

How to test?

• Describe the testing approach taken to verify the changes, including:
  • Unit tests
  • Should test on heroku by creating these efile errors & put client in rejected state
• Risk Assessment
  • I hate it, but there's supposed to be a long-term solution coming soon, that probably involves some kind of mapping between related issues

[arinchoi03]

I tried to do last_efile_errors.last here but this breaks a bunch of specs on return_status_controller_spec.rb...any idea why? 🤔

[arinchoi03]

ok this is weird, if i run the broken specs one-by-one, they start passing:

rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:1:1:1:4:1:3]' # StateFile::Questions::ReturnStatusController az #edit assignment of various instance variables efile error should expose error when cancelled, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:2:1:1:4:1:2]' # StateFile::Questions::ReturnStatusController id #edit assignment of various instance variables efile error should expose error when waiting, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:3:1:1:4:1:1]' # StateFile::Questions::ReturnStatusController md #edit assignment of various instance variables efile error should expose error when notified_of_rejection, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:3:1:1:4:1:2]' # StateFile::Questions::ReturnStatusController md #edit assignment of various instance variables efile error should expose error when waiting, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:4:1:1:4:1:1]' # StateFile::Questions::ReturnStatusController nc #edit assignment of various instance variables efile error should expose error when notified_of_rejection, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:4:1:1:4:1:3]' # StateFile::Questions::ReturnStatusController nc #edit assignment of various instance variables efile error should expose error when cancelled, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:4:1:5:4:3]' # StateFile::Questions::ReturnStatusController nc #edit rejected auto-wait error shows a generic message when resolution not present
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:5:1:1:4:1:3]' # StateFile::Questions::ReturnStatusController nj #edit assignment of various instance variables efile error should expose error when cancelled, assigns the last efile error attached to the last rejected transition
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:5:1:5:3:1]' # StateFile::Questions::ReturnStatusController nj #edit rejected auto-cancel error shows next steps when present
rspec './spec/controllers/state_file/questions/return_status_controller_spec.rb[1:5:1:5:4:3]' # StateFile::Questions::ReturnStatusController nj #edit rejected auto-wait error shows a generic message when resolution not present

[arinchoi03]

@mrotondo @jenny-heath ty for looking at this together! Summary: we didn't figure out exactly why this is happening...but some part of the issue is that the &.last on the efile errors is not returning the order we expect it to be consistently. Going to add this as an issue to address in the long-term story.

Please add notes if you want to the next jira ticket for the long-term solve or here

[github-actions]

Heroku app: https://gyr-review-app-5528-3a2208354159.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5528 (optionally add --tail)

[arinchoi03]

there are more than 2 related errors for MD, but thought 2 were enough -- lmk if we want to test all of them

[mrotondo]

Thanks for making this change, and working through the complications!