FYST 1747 Strip soft dash from employer state id number #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anisha Ramnani <[email protected]>
|
Heroku app: https://gyr-review-app-5523-6335ce5df499.herokuapp.com/ |
…ployer-state-id-num Co-authored-by: Anisha Ramnani <[email protected]>
Co-authored-by: Anisha Ramnani <[email protected]>
Co-authored-by: Anisha Ramnani <[email protected]>
tahsinaislam
deleted the
FYST-1747-all-states-strip-soft-dash-from-employer-state-id-num
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-1747
Is PM acceptance required?
What was done?
Fixed validation error caused by soft hyphens (U+AD00) in employer_state_id_num field
Added delete("\u00AD") to remove soft hyphens during XML generation while preserving original value
How to test?
Added a unit test for state file w2 model