Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NJ 269 - populate fill if paying by check/card in PDF #5515

Merged
merged 4 commits into from
Feb 5, 2025
Merged

NJ 269 - populate fill if paying by check/card in PDF #5515

merged 4 commits into from
Feb 5, 2025

Conversation

aloverso
Copy link
Contributor

@aloverso aloverso commented Feb 4, 2025

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/269

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Check line 79 box when: a) owes a balance AND b) selected directed deposit
  • Do not check otherwise (if no balance owed, or if selected pay by mail)

How to test?

  • Use Lucky Single to test a persona who owes a balance
  • Use Oneal MFJ for a persona who does not owe a balance

Screenshots (for visual changes)

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Heroku app: https://gyr-review-app-5515-a0b5f6a8d0ca.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5515 (optionally add --tail)

mrotondo
mrotondo approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mrotondo mrotondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One non-blocking rspec style suggestion, lmk if it's not clear & I can hop on tuple

@aloverso aloverso force-pushed the nj-269-paying-by-echeck-credit-card-pdf branch from 4b0e3ed to 2fc62af Compare February 5, 2025 15:54
@aloverso aloverso merged commit fc7feac into main Feb 5, 2025
7 checks passed
@aloverso aloverso deleted the nj-269-paying-by-echeck-credit-card-pdf branch February 5, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrotondo mrotondo mrotondo approved these changes

@mluedke2 mluedke2 mluedke2 approved these changes

@mmazanec22 mmazanec22 mmazanec22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aloverso @mrotondo @mluedke2 @mmazanec22