-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GYR1-654] Fixes/updates for p1 of 14-C both Hub and mappings #5501
Merged
spompea-cfa
merged 11 commits into
main
from
gyr1-654-fixes-updates-for-p1-of-hub-and-mappings
Feb 20, 2025
Merged
[GYR1-654] Fixes/updates for p1 of 14-C both Hub and mappings #5501
spompea-cfa
merged 11 commits into
main
from
gyr1-654-fixes-updates-for-p1-of-hub-and-mappings
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heroku app: https://gyr-review-app-5501-00a37fa0948c.herokuapp.com/ |
d817ec9
to
26358a4
Compare
c2c36f9
to
e07c063
Compare
e07c063
to
ddf4fd1
Compare
embarnard
approved these changes
Feb 10, 2025
embarnard
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema conflict but other wise looks good!
thank you! will rebase. |
b398120
to
bcd76d4
Compare
bcd76d4
to
0f48cc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira issue
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
primary or psouse) in the Hub 14-C; to allows this, switched over from
hardcoding this (in the mappings) and made it so default values of 'no' are
assigned inside the TriageIncomeController form class.
ensured these five fields match the ty2024 PDF. For the two "Other" fields:
created migration for a new db col:
refund_other_cb
for the checkbox;existing
refund_other
stays the same (as a string). (Fyi: there's also alegacy enum called
refund_payment_method
in intake.rb (it looks like this{ unfilled: 0, direct_deposit: 1, check: 2 }
). It's not used by GYR right now;it was being used by the now-defunct CTC; and it might be used by FYST (?) ...
i couldn't tell for sure.)
and mappings. Includes migration for a new db column.
How to test?
All of these changes have to do with the Hub editable 14-C page 1 and/or the
ty2024 PDF page 1.
assets" (just after intake flow) is "No". (Reason: this should be set when
client says 'no' to the "Did you earn income from a rental property (ex: home
or car), a farm, or cryptocurrency?" question on
Questions::TriageIncomeLevelController.)
digital assets" (both primary and spouse), those show up ok on the PDF,
OK and that the values show up OK on the PDF.
intake flow, that -- in the "If due a refund" section on both the Hub and PDF
-- (a) the "Refund Other" checkbox is checked and (b) the value for the
"Explain" field says "Purchase US Savings Bond".
values are entered in the Hub, they all show up OK on the pdf.
on the Hub and that if the value is 'yes' in the Hub, that the checkbox is
checked on the PDF.
Screenshots (for visual changes)
Before: see demo.
After: new/tweaked fields are highlighted w/ orange rectangles in the
screenshots.