Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GYR1-654] Fixes/updates for p1 of 14-C both Hub and mappings #5501

Merged
merged 11 commits into from
Feb 20, 2025

Conversation

spompea-cfa
Copy link
Contributor

@spompea-cfa spompea-cfa commented Feb 1, 2025

Link to Jira issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Digital Currencies fields: now allows partner to set this to 'yes' (for
    primary or psouse) in the Hub 14-C; to allows this, switched over from
    hardcoding this (in the mappings) and made it so default values of 'no' are
    assigned inside the TriageIncomeController form class.
  • Added visa yes/no widgets to the Hub editable 14-C page 1.
  • "If due a refund fields": tweaked mappings for refund payment options +
    ensured these five fields match the ty2024 PDF. For the two "Other" fields:
    created migration for a new db col: refund_other_cb for the checkbox;
    existing refund_other stays the same (as a string). (Fyi: there's also a
    legacy enum called refund_payment_method in intake.rb (it looks like this { unfilled: 0, direct_deposit: 1, check: 2 }). It's not used by GYR right now;
    it was being used by the now-defunct CTC; and it might be used by FYST (?) ...
    i couldn't tell for sure.)
  • Added the question "If married, were you married for all of 2024" to the Hub
    and mappings. Includes migration for a new db column.

How to test?

All of these changes have to do with the Hub editable 14-C page 1 and/or the
ty2024 PDF page 1.

  • Check that in the Hub the default value for "Owner or holder of any digital
    assets" (just after intake flow) is "No". (Reason: this should be set when
    client says 'no' to the "Did you earn income from a rental property (ex: home
    or car), a farm, or cryptocurrency?" question on
    Questions::TriageIncomeLevelController.)
  • Check that when values are picked in the Hub for "Owner or holder of any
    digital assets" (both primary and spouse), those show up ok on the PDF,
  • Check that the "In U.S. on a visa" and "Spouse in U.S. on a visa" fields work
    OK and that the values show up OK on the PDF.
  • Check that, if the client said "yes" on the savings bond question during the
    intake flow, that -- in the "If due a refund" section on both the Hub and PDF
    -- (a) the "Refund Other" checkbox is checked and (b) the value for the
    "Explain" field says "Purchase US Savings Bond".
  • Check, for all 5 fields of the "If due a refund" section, that when custom
    values are entered in the Hub, they all show up OK on the pdf.
  • Check that the "If married, were you married for all of 2024" question works
    on the Hub and that if the value is 'yes' in the Hub, that the checkbox is
    checked on the PDF.

Screenshots (for visual changes)

Before: see demo.

After: new/tweaked fields are highlighted w/ orange rectangles in the
screenshots.

Screenshot 2025-02-06 at 3 11 36 PM Screenshot 2025-02-06 at 3 11 50 PM

@spompea-cfa spompea-cfa changed the title [wip] GYR1-654 [wip] GYR1-654 Fixes/updates for p1 of 14-C both Hub and mappings Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

Heroku app: https://gyr-review-app-5501-00a37fa0948c.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5501 (optionally add --tail)

@spompea-cfa spompea-cfa force-pushed the gyr1-654-fixes-updates-for-p1-of-hub-and-mappings branch from d817ec9 to 26358a4 Compare February 4, 2025 20:20
@spompea-cfa spompea-cfa force-pushed the gyr1-654-fixes-updates-for-p1-of-hub-and-mappings branch from c2c36f9 to e07c063 Compare February 6, 2025 04:13
@spompea-cfa spompea-cfa changed the title [wip] GYR1-654 Fixes/updates for p1 of 14-C both Hub and mappings GYR1-654 Fixes/updates for p1 of 14-C both Hub and mappings Feb 6, 2025
@spompea-cfa spompea-cfa force-pushed the gyr1-654-fixes-updates-for-p1-of-hub-and-mappings branch from e07c063 to ddf4fd1 Compare February 6, 2025 21:22
Copy link
Contributor

@embarnard embarnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema conflict but other wise looks good!

@spompea-cfa
Copy link
Contributor Author

Schema conflict but other wise looks good!

thank you! will rebase.

@spompea-cfa spompea-cfa force-pushed the gyr1-654-fixes-updates-for-p1-of-hub-and-mappings branch from b398120 to bcd76d4 Compare February 11, 2025 21:27
@spompea-cfa spompea-cfa changed the title GYR1-654 Fixes/updates for p1 of 14-C both Hub and mappings [GYR1-654] Fixes/updates for p1 of 14-C both Hub and mappings Feb 13, 2025
@spompea-cfa spompea-cfa force-pushed the gyr1-654-fixes-updates-for-p1-of-hub-and-mappings branch from bcd76d4 to 0f48cc9 Compare February 19, 2025 23:59
@spompea-cfa spompea-cfa merged commit e198074 into main Feb 20, 2025
7 checks passed
@spompea-cfa spompea-cfa deleted the gyr1-654-fixes-updates-for-p1-of-hub-and-mappings branch February 20, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants