FYST-843 Implement MD502R XML/PDF Part 2: disability, retirement/pension income #5489
Conversation
|
Heroku app: https://gyr-review-app-5489-78676a7367ab.herokuapp.com/ |
arinchoi03
changed the title
…-502-r-retirement-income-xml-pdf-part-2
Co-authored-by: Anisha Ramnani <[email protected]>
arinchoi03
changed the title
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
these methods were added to the intake b/c other calculators will need this logic as well
| if state_file_1099_r.state_specific_followup&.send(followup_type) | ||
| state_file_1099_r.taxable_amount&.round | ||
| else | ||
| 0 |
There was a problem hiding this comment.
there was no strict requirement that if a 1099r followup was not present (or if it didn't match the followup_type for this 1099R) that it should return nilvs0`.
Since handling nil for summation (downstream too, not just in this block) can be tricky, chose to not go down this route unless needed for simplicity
…-502-r-retirement-income-xml-pdf-part-2
arinchoi03
deleted the
FYST-843-md-implement-form-502-r-retirement-income-xml-pdf-part-2
branch
| end | ||
| end | ||
|
|
||
| def sum_1099_r_followup_type_for_filer(filer_1099_rs, followup_type) |
There was a problem hiding this comment.
do we need to pass in the filer_1099_rs here? or instead should we pass in primary or spouse?
There was a problem hiding this comment.
ooh we can pass in the primary_or_spouse here and call the filer_1099_rs method from within this method!
Link to pivotal/JIRA issue
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
dorothy_mfj_1099_rScreenshots (for visual changes)