FYST 1724 NC and NJ to include NRA status in state xml if present on df xml #5486
Conversation
|
Heroku app: https://gyr-review-app-5486-99a5be932233.herokuapp.com/ |
| "no1099Amount": null | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
this persona was added after a conversation with tiffany to test on demo
| @@ -393,9 +393,22 @@ | |||
|
|
|||
| context "AZ intake" do | |||
| let(:intake) { create(:state_file_az_intake,) } | |||
| let(:submission) { create(:efile_submission, data_source: intake) } | |||
| let(:doc) { SubmissionBuilder::ReturnHeader.new(submission).document } | |||
| it "does not include disaster relief xml" do | |||
There was a problem hiding this comment.
this test was not properly testing the xml itself before. Its unrelated to the story
| @@ -43,15 +43,20 @@ def document | |||
| xml.DateSigned date_type_for_timezone(@submission.data_source.primary_esigned_at)&.strftime("%F") if @submission.data_source.primary_esigned_yes? | |||
| xml.USPhone @submission.data_source.direct_file_data.phone_number if @submission.data_source.direct_file_data.phone_number.present? | |||
| end | |||
| if @submission.data_source&.spouse&.ssn.present? && @submission.data_source&.spouse&.first_name.present? && [email protected]_status_mfs? | |||
| has_nra_spouse = @intake.check_nra_status? && @intake.direct_file_data.non_resident_alien == "NRA" && @intake.filing_status_mfs? | |||
| if @submission.data_source&.spouse&.ssn.present? && @submission.data_source&.spouse&.first_name.present? && ([email protected]_status_mfs? || has_nra_spouse) | |||
There was a problem hiding this comment.
will @submission.data_source ever return nil? I think we can remove the first &
There was a problem hiding this comment.
with this addition, when the filer is filing_status_mfs && has_nra_spouse -- we are also newly including the TaxPayerName, DateOfBirth, TaxPayerPIN etc information with the xml. Just making sure that that's a change that prod is expecting and should not be a source of issue downstream
There was a problem hiding this comment.
super good question! talked with tiffany we should include the fields. Things like PIN wont be included in a mfs filing anyways
| xml.TaxpayerSSN @submission.data_source.spouse.ssn if @submission.data_source.spouse.ssn.present? | ||
| if has_nra_spouse | ||
| xml.NRALiteralCd "NRA" | ||
| elsif @submission.data_source.spouse.ssn.present? |
There was a problem hiding this comment.
does this need to be @submission.data_source.spouse&.ssn&.present?
There was a problem hiding this comment.
probably not because its after if @submission.data_source.spouse&.ssn&.present? so maybe its redundant?
tahsinaislam
changed the title
tahsinaislam
deleted the
FYST-1724-nc-md-include-nra-literal-cd-in-state-xml-if-present-on-df-xml
branch
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-1724
Is PM acceptance required? (delete one)
What was done?
How to test?
Screenshots (for visual changes)