Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use uri to make token storage key unique #239

Merged
merged 6 commits into from
Nov 24, 2023
Merged

fix: use uri to make token storage key unique #239

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
208c207
fix: move token generation to agent (#1)
dballance Feb 1, 2023
7c592e2
fix: add uri to token storage key to prevent clashes (#2)
dballance Feb 1, 2023
4f7a5a9
Catch up with upstream (#3)
jmhossler Mar 17, 2023
81a4cce
chore: run mix format on our changes (#4)
jmhossler Mar 17, 2023
baf84ac
Add config URI when looking up token storage key to ensure dev/prod c…
jmhossler Mar 17, 2023
e182815
chore: undo random formatting changes that aren't necessary
jmhossler Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/pigeon/apns/token.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ defmodule Pigeon.APNS.Token do

@spec get(JWTConfig.t()) :: t
def get(%JWTConfig{} = config) do
token_storage_key = config.key_identifier <> ":" <> config.team_id
token_storage_key =
config.key_identifier <> ":" <> config.team_id <> ":" <> config.uri

Agent.get_and_update(__MODULE__, fn map ->
{timestamp, saved_token} = Map.get(map, token_storage_key, {0, nil})
Expand Down