Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase spawnsync buffer #716

Merged
merged 4 commits into from
Apr 19, 2022
Merged

fix: increase spawnsync buffer #716

merged 4 commits into from
Apr 19, 2022

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Apr 14, 2022

Fixes the issue here where running gcov exceeds the buffer size. Also removes unused argument from token.ts

@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner April 14, 2022 19:18
@thomasrockhu-codecov
Copy link
Contributor Author

@drazisil-codecov @mitchell-codecov I'm actually not sure why this is. I can repro locally, but removing the line makes all the tests run.

What I've found is adding the { maxBuffer: ... } ish returns undefined for result instead of the object. I have no idea why this is.

@thomasrockhu-codecov
Copy link
Contributor Author

Ok, so tests are breaking I believe because of the way we are mocking out spawnSync, will try to keep digging

@thomasrockhu-codecov
Copy link
Contributor Author

I know that's true, because removing the testdouble calls in a test (and changing the values to actual slugs or whatnot) result in passing tests

Co-authored-by: Mitchell Borrego <[email protected]>
Copy link
Contributor

@mitchell-codecov mitchell-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should evaluate how we're mocking spawnSync in a future PR. It seems unnecessary to have to update each individual mock of the function just to accommodate implementation-level changes in runExternalProgram.

@thomasrockhu-codecov thomasrockhu-codecov merged commit 530c53c into main Apr 19, 2022
@thomasrockhu-codecov thomasrockhu-codecov deleted the fix-spawn-buffer branch April 19, 2022 17:26
@thomasrockhu-codecov
Copy link
Contributor Author

@mitchell-codecov agreed, it seems unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants