-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase spawnsync buffer #716
Conversation
c43d4a0
to
a758b90
Compare
@drazisil-codecov @mitchell-codecov I'm actually not sure why this is. I can repro locally, but removing the line makes all the tests run. What I've found is adding the |
Ok, so tests are breaking I believe because of the way we are mocking out |
I know that's true, because removing the |
c264011
to
5bccea8
Compare
5bccea8
to
af8bea4
Compare
Co-authored-by: Mitchell Borrego <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should evaluate how we're mocking spawnSync
in a future PR. It seems unnecessary to have to update each individual mock of the function just to accommodate implementation-level changes in runExternalProgram
.
@mitchell-codecov agreed, it seems unnecessary |
Fixes the issue here where running
gcov
exceeds the buffer size. Also removes unused argument fromtoken.ts