Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various usability tweaks on the members page #3805

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

spalmurray-codecov
Copy link
Contributor

  • Adds a spinner to indicate the query is in flight.
  • To achieve the spinners on members list I did a refactor that pulls the mutation down into the table component itself. Also gets rid of unnecessary prop drilling.
  • Prevents the toggle div from filling the whole card width (whole div is clickable).
  • Right aligns toggles in the members list.

Closes codecov/engineering-team#3325

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 11, 2025 17:03
@@ -339,123 +291,4 @@ describe('MembersList', () => {
})
})
})

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic for this was moved down to MembersTable, so moved the tests for this logic there as well.

Copy link

codecov bot commented Mar 11, 2025

Bundle Report

Changes will increase total bundle size by 432 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-esm 6.19MB 209 bytes (0.0%) ⬆️
gazebo-production-system 6.11MB 223 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 71 bytes 12.55kB 0.57%
assets/ownerHelpers.*.js 138 bytes 2.27kB 6.47% ⚠️

Files in assets/index.*.js:

  • ./src/pages/MembersPage/MembersList/MembersList.jsx → Total Size: 3.19kB

  • ./src/pages/MembersPage/MembersActivation/AutoActivate/AutoActivate.jsx → Total Size: 1.0kB

  • ./src/pages/MembersPage/MembersList/MembersTable/MembersTable.tsx → Total Size: 6.84kB

Files in assets/ownerHelpers.*.js:

  • ./src/services/users/useUpdateUser.js → Total Size: 1.36kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 81 bytes 12.02kB 0.68%
assets/ownerHelpers-legacy.*.js 142 bytes 2.19kB 6.92% ⚠️

Files in assets/index-legacy.*.js:

  • ./src/pages/MembersPage/MembersList/MembersList.jsx → Total Size: 3.19kB

  • ./src/pages/MembersPage/MembersList/MembersTable/MembersTable.tsx → Total Size: 6.84kB

  • ./src/pages/MembersPage/MembersActivation/AutoActivate/AutoActivate.jsx → Total Size: 1.0kB

Files in assets/ownerHelpers-legacy.*.js:

  • ./src/services/users/useUpdateUser.js → Total Size: 1.36kB

@codecov-staging
Copy link

codecov-staging bot commented Mar 11, 2025

Bundle Report

Changes will increase total bundle size by 284 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB 148 bytes (0.0%) ⬆️
gazebo-staging-esm 6.19MB 136 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 99 bytes 12.58kB 0.79%
assets/ownerHelpers.*.js 37 bytes 2.17kB 1.74%

Files in assets/index.*.js:

  • ./src/pages/MembersPage/MembersActivation/AutoActivate/AutoActivate.jsx → Total Size: 1.0kB

  • ./src/pages/MembersPage/MembersList/MembersList.jsx → Total Size: 3.19kB

  • ./src/pages/MembersPage/MembersList/MembersTable/MembersTable.tsx → Total Size: 6.93kB

Files in assets/ownerHelpers.*.js:

  • ./src/services/users/useUpdateUser.js → Total Size: 1.04kB
view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 111 bytes 12.05kB 0.93%
assets/ownerHelpers-legacy.*.js 37 bytes 2.09kB 1.8%

Files in assets/index-legacy.*.js:

  • ./src/pages/MembersPage/MembersList/MembersTable/MembersTable.tsx → Total Size: 6.93kB

  • ./src/pages/MembersPage/MembersList/MembersList.jsx → Total Size: 3.19kB

  • ./src/pages/MembersPage/MembersActivation/AutoActivate/AutoActivate.jsx → Total Size: 1.0kB

Files in assets/ownerHelpers-legacy.*.js:

  • ./src/services/users/useUpdateUser.js → Total Size: 1.04kB

Copy link

codecov-public-qa bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.73%. Comparing base (359ba95) to head (cdcb4cc).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/MembersPage/MembersList/MembersList.jsx 0.00% 1 Missing ⚠️
src/services/users/useUpdateUser.js 85.71% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #3805      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         826      826              
  Lines       14996    15001       +5     
  Branches     4287     4288       +1     
==========================================
+ Hits        14807    14811       +4     
- Misses        182      183       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...ge/MembersActivation/AutoActivate/AutoActivate.jsx 100.00% <100.00%> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <100.00%> (ø)
src/pages/MembersPage/MembersList/MembersList.jsx 94.44% <0.00%> (-5.56%) ⬇️
src/services/users/useUpdateUser.js 94.73% <85.71%> (-5.27%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.29% <95.65%> (-0.02%) ⬇️
Services 99.35% <85.71%> (-0.03%) ⬇️
Shared 99.12% <ø> (ø)
UI 99.15% <ø> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359ba95...cdcb4cc. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 11, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
5e30e6a Tue, 11 Mar 2025 17:07:41 GMT Expired Expired
5101704 Tue, 11 Mar 2025 17:29:46 GMT Expired Expired
181b69e Tue, 11 Mar 2025 17:36:24 GMT Expired Expired
71c43ea Tue, 11 Mar 2025 18:06:00 GMT Expired Expired
4620be6 Tue, 11 Mar 2025 19:13:06 GMT Expired Expired
f1c4162 Tue, 11 Mar 2025 19:24:43 GMT Expired Expired
609b473 Tue, 11 Mar 2025 19:41:48 GMT Expired Expired
31d925e Wed, 12 Mar 2025 19:14:08 GMT Expired Expired
b2226b0 Thu, 13 Mar 2025 18:07:21 GMT Expired Expired
178a33e Thu, 13 Mar 2025 18:22:14 GMT Expired Expired
cdcb4cc Thu, 13 Mar 2025 19:23:44 GMT Cloud Enterprise

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/MembersPage/MembersList/MembersList.jsx 0.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main    #3805   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14994    14998    +4     
  Branches     4285     4286    +1     
=======================================
+ Hits        14805    14809    +4     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
...ge/MembersActivation/AutoActivate/AutoActivate.jsx 100.00% <100.00%> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <100.00%> (ø)
src/services/users/useUpdateUser.js 100.00% <100.00%> (ø)
src/pages/MembersPage/MembersList/MembersList.jsx 94.44% <0.00%> (-5.56%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.29% <96.00%> (-0.02%) ⬇️
Services 99.38% <100.00%> (+<0.01%) ⬆️
Shared 99.12% <ø> (ø)
UI 99.15% <ø> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b914c70...71c43ea. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.73%. Comparing base (359ba95) to head (cdcb4cc).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/MembersPage/MembersList/MembersList.jsx 0.00% 1 Missing ⚠️
src/services/users/useUpdateUser.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3805      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         826      826              
  Lines       14996    15001       +5     
  Branches     4279     4280       +1     
==========================================
+ Hits        14807    14811       +4     
- Misses        182      183       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...ge/MembersActivation/AutoActivate/AutoActivate.jsx 100.00% <100.00%> (ø)
...bersPage/MembersList/MembersTable/MembersTable.tsx 100.00% <100.00%> (ø)
src/pages/MembersPage/MembersList/MembersList.jsx 94.44% <0.00%> (-5.56%) ⬇️
src/services/users/useUpdateUser.js 94.73% <85.71%> (-5.27%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.29% <95.65%> (-0.02%) ⬇️
Services 99.35% <85.71%> (-0.03%) ⬇️
Shared 99.12% <ø> (ø)
UI 99.15% <ø> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359ba95...cdcb4cc. Read the comment docs.

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/fix-activation-toggles-members-page branch from 609b473 to 31d925e Compare March 12, 2025 19:08
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/fix-activation-toggles-members-page branch from 31d925e to b2226b0 Compare March 13, 2025 18:02
Copy link
Contributor

sentry-autofix bot commented Mar 13, 2025

✅ Sentry found no issues in your recent changes ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org > member delay when selecting auto-activation or member activation
3 participants