-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add spinner to Toggle component #3803
Conversation
Bundle ReportChanges will increase total bundle size by 1.19kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 1.19kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3803 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14975 +5
Branches 4265 4278 +13
=======================================
+ Hits 14781 14786 +5
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3803 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14975 +5
Branches 4265 4270 +5
=======================================
+ Hits 14781 14786 +5
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3803 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14975 +5
Branches 4273 4270 -3
=======================================
+ Hits 14781 14786 +5
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
This PR adds an optional spinner on the Toggle component that can be triggered by a new isLoading prop.
To be used in codecov/engineering-team#3325