Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add spinner to Toggle component #3803

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Mar 11, 2025

This PR adds an optional spinner on the Toggle component that can be triggered by a new isLoading prop.

To be used in codecov/engineering-team#3325

Recording 2025-03-11 at 09 22 04

@codecov-staging
Copy link

codecov-staging bot commented Mar 11, 2025

Bundle Report

Changes will increase total bundle size by 1.19kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB 595 bytes (0.01%) ⬆️
gazebo-staging-esm 6.18MB 597 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 595 bytes 718.22kB 0.08%

Files in assets/index-legacy.*.js:

  • ./src/ui/Toggle/Toggle.tsx → Total Size: 3.25kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 255 bytes 639.15kB 0.04%
assets/index.*.css 342 bytes 101.4kB 0.34%

Files in assets/index.*.js:

  • ./src/ui/Toggle/Toggle.tsx → Total Size: 3.25kB

Copy link

codecov bot commented Mar 11, 2025

Bundle Report

Changes will increase total bundle size by 1.19kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB 595 bytes (0.01%) ⬆️
gazebo-production-esm 6.18MB 597 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 255 bytes 639.15kB 0.04%
assets/index.*.css 342 bytes 101.4kB 0.34%

Files in assets/index.*.js:

  • ./src/ui/Toggle/Toggle.tsx → Total Size: 3.25kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 595 bytes 718.22kB 0.08%

Files in assets/index-legacy.*.js:

  • ./src/ui/Toggle/Toggle.tsx → Total Size: 3.25kB

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (535feae) to head (8cbaa74).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3803   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14975    +5     
  Branches     4265     4278   +13     
=======================================
+ Hits        14781    14786    +5     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/Toggle/Toggle.tsx 94.73% <100.00%> (+1.87%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.08% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535feae...8cbaa74. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3803   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14975    +5     
  Branches     4265     4270    +5     
=======================================
+ Hits        14781    14786    +5     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/Toggle/Toggle.tsx 94.73% <100.00%> (+1.87%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.08% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535feae...8cbaa74. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review March 11, 2025 13:23
Copy link

codecov-public-qa bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (535feae) to head (8cbaa74).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3803   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14970    14975    +5     
  Branches     4273     4270    -3     
=======================================
+ Hits        14781    14786    +5     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/Toggle/Toggle.tsx 94.73% <100.00%> (+1.87%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <ø> (ø)
Shared 99.12% <ø> (ø)
UI 99.08% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535feae...8cbaa74. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 11, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
2dfe356 Tue, 11 Mar 2025 13:24:50 GMT Expired Expired
9f8f546 Tue, 11 Mar 2025 13:32:36 GMT Expired Expired
8cbaa74 Tue, 11 Mar 2025 13:47:57 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov self-requested a review March 11, 2025 13:34
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 76c721a Mar 11, 2025
54 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/spinny-toggle branch March 11, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants