Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update login nav link to append to redirect #3799

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the login nav link to support appending a to parameter that is used to redirect the user after they have logged in and been redirected from the API.

Closes codecov/engineering-team#3451

Notable Changes

  • Move login to useNavLinks, and add support for appending query string
  • Update tests

@nicholas-codecov nicholas-codecov changed the title feat: Update login nav link to support redirect feat: Update login nav link to append to redirect Mar 10, 2025
@codecov-staging
Copy link

codecov-staging bot commented Mar 10, 2025

Bundle Report

Changes will increase total bundle size by 162 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.11MB 75 bytes (0.0%) ⬆️
gazebo-staging-esm 6.18MB 87 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 87 bytes 638.89kB 0.01%

Files in assets/index.*.js:

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.51kB

  • ./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.82kB

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 75 bytes 717.63kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.53kB

  • ./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.82kB

Copy link

codecov bot commented Mar 10, 2025

Bundle Report

Changes will increase total bundle size by 162 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.11MB 75 bytes (0.0%) ⬆️
gazebo-production-esm 6.18MB 87 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 75 bytes 717.63kB 0.01%

Files in assets/index-legacy.*.js:

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.53kB

  • ./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.82kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 87 bytes 638.89kB 0.01%

Files in assets/index.*.js:

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.51kB

  • ./src/services/navigation/useStaticNavLinks.ts → Total Size: 16.82kB

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3799   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14969    14970    +1     
  Branches     4272     4265    -7     
=======================================
+ Hits        14780    14781    +1     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 99.03% <100.00%> (+0.01%) ⬆️
src/services/navigation/useStaticNavLinks.ts 98.85% <ø> (-0.06%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <100.00%> (+<0.01%) ⬆️
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6e9b5...7c580e2. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (fa6e9b5) to head (7c580e2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3799   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         826      826           
  Lines       14969    14970    +1     
  Branches     4264     4265    +1     
=======================================
+ Hits        14780    14781    +1     
  Misses        182      182           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 99.03% <100.00%> (+0.01%) ⬆️
src/services/navigation/useStaticNavLinks.ts 98.85% <ø> (-0.06%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.30% <ø> (ø)
Services 99.38% <100.00%> (+<0.01%) ⬆️
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6e9b5...7c580e2. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (ba49650) to head (8e613bd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3799   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         826      826           
  Lines       14955    14956    +1     
  Branches     4269     4262    -7     
=======================================
+ Hits        14767    14768    +1     
  Misses        181      181           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 99.03% <100.00%> (+0.01%) ⬆️
src/services/navigation/useStaticNavLinks.ts 98.85% <ø> (-0.06%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.31% <ø> (ø)
Services 99.38% <100.00%> (+<0.01%) ⬆️
Shared 99.12% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba49650...8e613bd. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 10, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
8e613bd Mon, 10 Mar 2025 12:41:10 GMT Expired Expired
7c580e2 Mon, 10 Mar 2025 13:29:36 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 7c85c05 Mar 10, 2025
54 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3451-feat-update-login-nav-link-to-support-redirect branch March 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Update /login to support redirect option
3 participants