-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Vendor split large and common packages and remove unused deps #3728
chore: Vendor split large and common packages and remove unused deps #3728
Conversation
Bundle ReportChanges will increase total bundle size by 68.45kB (0.55%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
view changes for bundle: gazebo-staging-esmAssets Changed:
|
Bundle ReportChanges will increase total bundle size by 68.45kB (0.55%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
view changes for bundle: gazebo-production-systemAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 826 826
Lines 14867 14867
Branches 4229 4221 -8
=======================================
Hits 14695 14695
Misses 166 166
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 826 826
Lines 14867 14867
Branches 4229 4221 -8
=======================================
Hits 14695 14695
Misses 166 166
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 826 826
Lines 14867 14867
Branches 4229 4229
=======================================
Hits 14695 14695
Misses 166 166
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 826 826
Lines 14867 14867
Branches 4229 4229
=======================================
Hits 14695 14695
Misses 166 166
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, one q
Description
This PR vendor splits a couple of larger packages, and our icons. This PR also removes the
semver
package from ourpackage.json
as it is not actually being used in our application.Notable Changes
@sentry/react
,@amplitude/analytics-browser
,recharts
, our iconssemver
package