-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Org page UI improvements #3727
Conversation
Bundle ReportChanges will decrease total bundle size by 8.44kB (-0.07%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 824 824
Lines 14818 14795 -23
Branches 4239 4226 -13
==========================================
- Hits 14626 14603 -23
Misses 186 186
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 824 824
Lines 14818 14795 -23
Branches 4231 4234 +3
==========================================
- Hits 14626 14603 -23
Misses 186 186
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 824 824
Lines 14818 14795 -23
Branches 4239 4234 -5
==========================================
- Hits 14626 14603 -23
Misses 186 186
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 8.44kB (-0.07%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 824 824
Lines 14818 14795 -23
Branches 4231 4234 +3
==========================================
- Hits 14626 14603 -23
Misses 186 186
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
5d41d4a
to
0eac8bc
Compare
0eac8bc
to
1c0c204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about a potential regression in functionality regarding the ability to sync repos.
onChange={(e) => setSearch(e.target.value)} | ||
data-testid="org-control-search" | ||
/> | ||
{canRefetch && <RepoOrgNotFound />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we removing the ability for users to refetch/sync their repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh okay 👍
Description
codecov/engineering-team#2263

Implementing bullet 1 and 2 of this section of the ticket
Figma: https://www.figma.com/design/G5bVKsd2uceVqw3JrSRFQ4/GH-2263?node-id=96-2894&t=fp5mlLHxOrSqyMTY-1
Code Example
Notable Changes
Screenshots
Search bar without the All/Configured/Not configured buttons

Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.