Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Org page UI improvements #3727

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Feb 11, 2025

Description

codecov/engineering-team#2263
Implementing bullet 1 and 2 of this section of the ticket
Screenshot 2025-02-12 at 11 11 58 AM

Figma: https://www.figma.com/design/G5bVKsd2uceVqw3JrSRFQ4/GH-2263?node-id=96-2894&t=fp5mlLHxOrSqyMTY-1

Code Example

Notable Changes

  • Adding the feature to show the most recently clicked on repo at the top of the list

Screenshots

Search bar without the All/Configured/Not configured buttons
Screenshot 2025-02-12 at 9 02 04 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Feb 11, 2025

Bundle Report

Changes will decrease total bundle size by 8.44kB (-0.07%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.13MB -4.0kB (-0.07%) ⬇️
gazebo-staging-esm 6.21MB -4.44kB (-0.07%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -431 bytes 730.14kB -0.06%
assets/index-legacy.*.js -54 bytes 31.15kB -0.17%
assets/index-legacy.*.js 3.35kB 18.43kB 22.21% ⚠️
assets/index-legacy.*.js 4.95kB 15.08kB 48.9% ⚠️
assets/index-legacy.*.js -156 bytes 41.43kB -0.38%
assets/index-legacy.*.js -54 bytes 50.04kB -0.11%
assets/ReposTable-legacy.*.js -11.6kB 9.66kB -54.56%

Files in assets/index-legacy.*.js:

  • ./src/ui/TextInput/TextInput.tsx → Total Size: 1.84kB

Files in assets/index-legacy.*.js:

  • ./src/shared/ListRepo/ListRepo.tsx → Total Size: 2.17kB

  • ./src/shared/ListRepo/OrgControlTable/OrgControlTable.tsx → Total Size: 668 bytes

  • ./src/shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx → Total Size: 5.85kB

Files in assets/ReposTable-legacy.*.js:

  • ./src/shared/ListRepo/ReposTable/ReposTable.tsx → Total Size: 6.05kB

  • ./src/services/repos/ReposQueryOpts.tsx → Total Size: 3.17kB

  • ./src/shared/ListRepo/ReposTable/getReposColumnsHelper.tsx → Total Size: 2.34kB

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -544 bytes 651.0kB -0.08%
assets/index.*.js 5.16kB 19.41kB 36.26% ⚠️
assets/index.*.js 5 bytes 11.22kB 0.04%
assets/index.*.js -138 bytes 41.93kB -0.33%
assets/index.*.js -48 bytes 53.01kB -0.09%
assets/index.*.js 1.29kB 14.24kB 9.98% ⚠️
assets/index.*.js -48 bytes 31.8kB -0.15%
assets/index.*.js 2.37kB 12.95kB 22.38% ⚠️
assets/index.*.css 25 bytes 101.04kB 0.02%
assets/ReposTable.*.js -12.52kB 10.25kB -54.99%

Files in assets/index.*.js:

  • ./src/ui/TextInput/TextInput.tsx → Total Size: 1.82kB

Files in assets/index.*.js:

  • ./src/shared/ListRepo/ListRepo.tsx → Total Size: 2.17kB

  • ./src/shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx → Total Size: 5.85kB

  • ./src/shared/ListRepo/OrgControlTable/OrgControlTable.tsx → Total Size: 668 bytes

Files in assets/ReposTable.*.js:

  • ./src/shared/ListRepo/ReposTable/getReposColumnsHelper.tsx → Total Size: 2.34kB

  • ./src/shared/ListRepo/ReposTable/ReposTable.tsx → Total Size: 6.03kB

  • ./src/services/repos/ReposQueryOpts.tsx → Total Size: 3.17kB

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (de8f585) to head (028c89c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         824      824              
  Lines       14818    14795      -23     
  Branches     4239     4226      -13     
==========================================
- Hits        14626    14603      -23     
  Misses        186      186              
  Partials        6        6              
Files with missing lines Coverage Δ
src/services/repos/ReposQueryOpts.tsx 100.00% <ø> (ø)
src/shared/ListRepo/ListRepo.tsx 100.00% <100.00%> (ø)
...hared/ListRepo/OrgControlTable/OrgControlTable.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.57% <ø> (-0.04%) ⬇️
...ared/ListRepo/ReposTable/getReposColumnsHelper.tsx 100.00% <ø> (ø)
.../shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.26% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.35% <100.00%> (-0.02%) ⬇️
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8f585...028c89c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         824      824              
  Lines       14818    14795      -23     
  Branches     4231     4234       +3     
==========================================
- Hits        14626    14603      -23     
  Misses        186      186              
  Partials        6        6              
Files with missing lines Coverage Δ
src/services/repos/ReposQueryOpts.tsx 100.00% <ø> (ø)
src/shared/ListRepo/ListRepo.tsx 100.00% <100.00%> (ø)
...hared/ListRepo/OrgControlTable/OrgControlTable.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.57% <ø> (-0.04%) ⬇️
...ared/ListRepo/ReposTable/getReposColumnsHelper.tsx 100.00% <ø> (ø)
.../shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.26% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.35% <100.00%> (-0.02%) ⬇️
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8f585...028c89c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (de8f585) to head (028c89c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         824      824              
  Lines       14818    14795      -23     
  Branches     4239     4234       -5     
==========================================
- Hits        14626    14603      -23     
  Misses        186      186              
  Partials        6        6              
Files with missing lines Coverage Δ
src/services/repos/ReposQueryOpts.tsx 100.00% <ø> (ø)
src/shared/ListRepo/ListRepo.tsx 100.00% <100.00%> (ø)
...hared/ListRepo/OrgControlTable/OrgControlTable.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.57% <ø> (-0.04%) ⬇️
...ared/ListRepo/ReposTable/getReposColumnsHelper.tsx 100.00% <ø> (ø)
.../shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.26% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.35% <100.00%> (-0.02%) ⬇️
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8f585...028c89c. Read the comment docs.

Copy link

codecov bot commented Feb 11, 2025

Bundle Report

Changes will decrease total bundle size by 8.44kB (-0.07%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.13MB -4.0kB (-0.07%) ⬇️
gazebo-production-esm 6.21MB -4.44kB (-0.07%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 3.35kB 18.43kB 22.21% ⚠️
assets/index-legacy.*.js -54 bytes 31.15kB -0.17%
assets/index-legacy.*.js -431 bytes 730.14kB -0.06%
assets/index-legacy.*.js -54 bytes 50.04kB -0.11%
assets/index-legacy.*.js -156 bytes 41.43kB -0.38%
assets/index-legacy.*.js 4.95kB 15.08kB 48.9% ⚠️
assets/ReposTable-legacy.*.js -11.6kB 9.66kB -54.56%

Files in assets/index-legacy.*.js:

  • ./src/shared/ListRepo/OrgControlTable/OrgControlTable.tsx → Total Size: 668 bytes

  • ./src/shared/ListRepo/ListRepo.tsx → Total Size: 2.17kB

  • ./src/shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx → Total Size: 5.85kB

Files in assets/index-legacy.*.js:

  • ./src/ui/TextInput/TextInput.tsx → Total Size: 1.84kB

Files in assets/ReposTable-legacy.*.js:

  • ./src/shared/ListRepo/ReposTable/getReposColumnsHelper.tsx → Total Size: 2.34kB

  • ./src/shared/ListRepo/ReposTable/ReposTable.tsx → Total Size: 6.05kB

  • ./src/services/repos/ReposQueryOpts.tsx → Total Size: 3.17kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -138 bytes 41.93kB -0.33%
assets/index.*.js 4.08kB 19.41kB 26.64% ⚠️
assets/index.*.js -544 bytes 651.0kB -0.08%
assets/index.*.js 2.37kB 15.32kB 18.33% ⚠️
assets/index.*.js 1.73kB 12.95kB 15.44% ⚠️
assets/index.*.js -48 bytes 53.01kB -0.09%
assets/index.*.js -48 bytes 31.8kB -0.15%
assets/index.*.js 641 bytes 11.22kB 6.06% ⚠️
assets/index.*.css 25 bytes 101.04kB 0.02%
assets/ReposTable.*.js -12.52kB 10.25kB -54.99%

Files in assets/index.*.js:

  • ./src/shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx → Total Size: 5.85kB

  • ./src/shared/ListRepo/ListRepo.tsx → Total Size: 2.17kB

  • ./src/shared/ListRepo/OrgControlTable/OrgControlTable.tsx → Total Size: 668 bytes

Files in assets/index.*.js:

  • ./src/ui/TextInput/TextInput.tsx → Total Size: 1.82kB

Files in assets/ReposTable.*.js:

  • ./src/shared/ListRepo/ReposTable/ReposTable.tsx → Total Size: 6.03kB

  • ./src/services/repos/ReposQueryOpts.tsx → Total Size: 3.17kB

  • ./src/shared/ListRepo/ReposTable/getReposColumnsHelper.tsx → Total Size: 2.34kB

Copy link

codecov-public-qa bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (de8f585) to head (028c89c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         824      824              
  Lines       14818    14795      -23     
  Branches     4231     4234       +3     
==========================================
- Hits        14626    14603      -23     
  Misses        186      186              
  Partials        6        6              
Files with missing lines Coverage Δ
src/services/repos/ReposQueryOpts.tsx 100.00% <ø> (ø)
src/shared/ListRepo/ListRepo.tsx 100.00% <100.00%> (ø)
...hared/ListRepo/OrgControlTable/OrgControlTable.tsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.57% <ø> (-0.04%) ⬇️
...ared/ListRepo/ReposTable/getReposColumnsHelper.tsx 100.00% <ø> (ø)
.../shared/ListRepo/ReposTableTeam/ReposTableTeam.tsx 100.00% <ø> (ø)
src/ui/TextInput/TextInput.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.26% <ø> (ø)
Services 99.24% <ø> (ø)
Shared 99.35% <100.00%> (-0.02%) ⬇️
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8f585...028c89c. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 11, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7ff18fa Tue, 11 Feb 2025 23:17:31 GMT Expired Expired
0eac8bc Wed, 12 Feb 2025 07:11:14 GMT Expired Expired
1c0c204 Wed, 12 Feb 2025 20:56:51 GMT Expired Expired
133554a Thu, 13 Feb 2025 00:30:03 GMT Expired Expired
028c89c Tue, 18 Feb 2025 21:30:59 GMT Cloud Enterprise

@calvin-codecov calvin-codecov force-pushed the cy/org_page_ui_improvements branch 2 times, most recently from 5d41d4a to 0eac8bc Compare February 12, 2025 07:05
@calvin-codecov calvin-codecov force-pushed the cy/org_page_ui_improvements branch from 0eac8bc to 1c0c204 Compare February 12, 2025 20:50
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about a potential regression in functionality regarding the ability to sync repos.

onChange={(e) => setSearch(e.target.value)}
data-testid="org-control-search"
/>
{canRefetch && <RepoOrgNotFound />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing the ability for users to refetch/sync their repos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh okay 👍

@calvin-codecov calvin-codecov added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit e215b11 Feb 18, 2025
62 checks passed
@calvin-codecov calvin-codecov deleted the cy/org_page_ui_improvements branch February 18, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants