ref: Migrate useReposCoverageMeasurements to TSQ V5 #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 264 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 264 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3712 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4231 4221 -10
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3712 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4223 4221 -2
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3712 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4223 4229 +6
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3712 +/- ##
==========================================
- Coverage 98.84% 98.84% -0.01%
==========================================
Files 826 826
Lines 14865 14862 -3
Branches 4231 4221 -10
==========================================
- Hits 14694 14691 -3
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| suspense?: boolean | ||
| keepPreviousData?: boolean | ||
| opts?: { | ||
| keepPrevious?: boolean | ||
| } | ||
| } | ||
|
|
||
| export const useCoverage = ({ |
There was a problem hiding this comment.
Does this really need its own hook/file? Guess it's a lot of code to repeat if we do call it in multiple places.
There was a problem hiding this comment.
Uhh ... i mean we cooooould probably get rid of it, buuuut I'd rather avoid the scope creep for this PR.
There was a problem hiding this comment.
acceptable answer 👍
spalmurray-codecov
approved these changes
Feb 10, 2025
nicholas-codecov
deleted the
gh-eng-3165-ref-useReposCoverageMeasurements-to-tsqv5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
useReposCoverageMeasurementsover to the query options versionReposCoverageMeasurementsQueryOpts.Ticket: codecov/engineering-team#3165
Notable Changes
useReposCoverageMeasurementstoReposCoverageMeasurementsQueryOptsuseCoverageChart.tsx