Refactor files changed table on commit detail page #2569
Conversation
rohitvinnakota-codecov
changed the title
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
+ Coverage 98.31 98.32 +0.01
=======================================
Files 820 820
Lines 10827 10868 +41
Branches 2775 2772 -3
=======================================
+ Hits 10644 10685 +41
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
|
Visit https://preview-pr-2569.codecov.dev for your PR preview. Expires after 1 month automatically. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 98.30% 98.31%
=======================================
Files 820 820
Lines 10827 10868 +41
Branches 2767 2782 +15
=======================================
+ Hits 10644 10685 +41
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 98.30% 98.31%
=======================================
Files 820 820
Lines 10827 10868 +41
Branches 2775 2737 -38
=======================================
+ Hits 10644 10685 +41
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 98.30% 98.31%
=======================================
Files 820 820
Lines 10827 10868 +41
Branches 2722 2737 +15
=======================================
+ Hits 10644 10685 +41
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
changed the title
Bundle ReportChanges will increase total bundle size by 8.27KB ⬆️
|
| @@ -75,7 +81,7 @@ const wrapper = | |||
| ) | |||
|
|
|||
| describe('FilesChangedTable', () => { | |||
| function setup(data = [], state = 'processed') { | |||
| function setup(data: any = null, state = 'processed') { | |||
There was a problem hiding this comment.
l: Is there any way to use the Zod schema to infer the data here?
…hub.com/codecov/gazebo into rvinnakota/commit-detail-table-refactor
…hub.com/codecov/gazebo into rvinnakota/commit-detail-table-refactor
rohitvinnakota-codecov
deleted the
rvinnakota/commit-detail-table-refactor
branch
Description
This PR refactors the
FilesChangedTableon the commit detail page to use tanstack. This closes codecov/engineering-team#585.Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.