Update flag select in pull request view to only show relevant flags #2531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 813 813
Lines 10622 10631 +9
Branches 2704 2665 -39
=======================================
+ Hits 10447 10456 +9
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 813 813
Lines 10622 10631 +9
Branches 2693 2706 +13
=======================================
+ Hits 10447 10456 +9
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
+ Coverage 98.29 98.34 +0.05
=======================================
Files 793 811 +18
Lines 10239 10570 +331
Branches 2532 2678 +146
=======================================
+ Hits 10064 10395 +331
Misses 173 173
Partials 2 2
... and 186 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 813 813
Lines 10622 10631 +9
Branches 2704 2663 -41
=======================================
+ Hits 10447 10456 +9
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
changed the title
|
Visit https://preview-pr-2531.codecov.dev for your PR preview. Expires after 1 month automatically. |
| const data = pullId | ||
| ? fetchRepoFlagsForPull({ | ||
| provider, | ||
| owner, | ||
| repo, | ||
| pullId, | ||
| signal, | ||
| filters, | ||
| after, | ||
| }) | ||
| : fetchRepoFlags({ | ||
| provider, | ||
| owner, | ||
| repo, | ||
| filters, | ||
| after, | ||
| signal, | ||
| }) |
There was a problem hiding this comment.
Rather then using a ternary here, can you swap to if statements with a default value. This will make it easier to add in the same for commits (I'm assuming that's going to be added) as well as making it easier to read.
Description
This PR closes codecov/engineering-team#823. Following up from codecov/codecov-api#350, we now only see relevant flags to the PR in the pull view. This uses the same query as in the flags tab.
The query used in the flags tab was modified to accept search terms to maintain behaviour in the Flags Select component
Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.