Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update GitHub Actions tab with GUT #2526

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Jan 22, 2024

Description

if user has GUT already generated, and if feature flag is on, we show GUT docs otherwise; we show old docs.

Notable Changes

  • Rename old docs to reflect repo specific docs
  • Create new org upload token doc
  • Tests and some restructure to display the correct component

Screenshots

Screenshot 2024-01-22 at 4 30 47 PM

closes: codecov/engineering-team#940

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Jan 22, 2024

Codecov Report

Merging #2526 (db8bc22) into main (e5e975b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2526   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         797      799    +2     
  Lines       10279    10291   +12     
  Branches     2533     2586   +53     
=======================================
+ Hits        10104    10116   +12     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <100.00%> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...db8bc22. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2526   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         797      799    +2     
  Lines       10279    10291   +12     
  Branches     2584     2581    -3     
=======================================
+ Hits        10104    10116   +12     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <100.00%> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...db8bc22. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5e975b) 98.29% compared to head (db8bc22) 98.29%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2526   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         797      799    +2     
  Lines       10279    10291   +12     
  Branches     2579     2567   -12     
=======================================
+ Hits        10104    10116   +12     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <100.00%> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...db8bc22. Read the comment docs.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit db8bc22
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65afb03aa0eb6e0007206091
😎 Deploy Preview https://deploy-preview-2526--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5e975b) 98.30% compared to head (db8bc22) 98.30%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2526   +/-   ##
=====================================
  Coverage   98.30   98.30           
=====================================
  Files        797     799    +2     
  Lines      10279   10291   +12     
  Branches    2584    2581    -3     
=====================================
+ Hits       10104   10116   +12     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 100.00% <100.00%> (ø)
...Onboarding/GitHubActions/GitHubActionsOrgToken.tsx 100.00% <100.00%> (ø)
...nboarding/GitHubActions/GitHubActionsRepoToken.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.26% <100.00%> (+<0.01%) ⬆️
Services 99.50% <ø> (ø)
Shared 99.82% <ø> (ø)
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e975b...db8bc22. Read the comment docs.

@RulaKhaled RulaKhaled marked this pull request as ready for review January 22, 2024 15:38
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick things to pick up, and just making sure the plan is to hold off rolling this out until the V4 action is fully released?

Comment on lines 40 to 41
Admin required to access repo settings {'>'} secrets and variable
{' >'} actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap the > to &gt;, that way we're using browser native symbols over this work around.

Comment on lines 42 to 43
Admin required to access repo settings {'>'} secrets and variable
{' >'} actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here, small update to using HTML symbols

@RulaKhaled
Copy link
Contributor Author

Two quick things to pick up, and just making sure the plan is to hold off rolling this out until the V4 action is fully released?

Yes, we're going to roll out when v4 is actually released so the feature flag is currently set to show for dashboard team only

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those two quick things up! Looks all good to me ✅

@RulaKhaled RulaKhaled merged commit 42af2c4 into main Jan 23, 2024
@RulaKhaled RulaKhaled deleted the gh-actions-gut-copy branch January 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo] Update step1 and step2 in Github Actions tab in new repo page
2 participants