-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update GitHub Actions tab with GUT #2526
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2526 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 797 799 +2
Lines 10279 10291 +12
Branches 2533 2586 +53
=======================================
+ Hits 10104 10116 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2526 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 797 799 +2
Lines 10279 10291 +12
Branches 2584 2581 -3
=======================================
+ Hits 10104 10116 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 797 799 +2
Lines 10279 10291 +12
Branches 2579 2567 -12
=======================================
+ Hits 10104 10116 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
=====================================
Coverage 98.30 98.30
=====================================
Files 797 799 +2
Lines 10279 10291 +12
Branches 2584 2581 -3
=====================================
+ Hits 10104 10116 +12
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick things to pick up, and just making sure the plan is to hold off rolling this out until the V4 action is fully released?
Admin required to access repo settings {'>'} secrets and variable | ||
{' >'} actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you swap the >
to >
, that way we're using browser native symbols over this work around.
Admin required to access repo settings {'>'} secrets and variable | ||
{' >'} actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, small update to using HTML symbols
Yes, we're going to roll out when v4 is actually released so the feature flag is currently set to show for dashboard team only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those two quick things up! Looks all good to me ✅
Description
if user has GUT already generated, and if feature flag is on, we show GUT docs otherwise; we show old docs.
Notable Changes
Screenshots
closes: codecov/engineering-team#940
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.