Refactor Repos table in owner page and analytics page #2518
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| isCurrentUserPartOfOrg: PropTypes.bool.isRequired, | ||
| activated: PropTypes.bool.isRequired, | ||
| active: PropTypes.bool.isRequired, | ||
| owner: PropTypes.string, |
There was a problem hiding this comment.
Long term fix here is to convert this file to typescript
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
=====================================
Coverage 98.36 98.36
=====================================
Files 813 814 +1
Lines 10653 10676 +23
Branches 2729 2717 -12
=====================================
+ Hits 10478 10501 +23
Misses 173 173
Partials 2 2
... and 10 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 813 814 +1
Lines 10653 10698 +45
Branches 2721 2732 +11
=======================================
+ Hits 10478 10523 +45
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 813 814 +1
Lines 10653 10698 +45
Branches 2710 2740 +30
=======================================
+ Hits 10478 10523 +45
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 813 814 +1
Lines 10653 10698 +45
Branches 2729 2689 -40
=======================================
+ Hits 10478 10523 +45
Misses 173 173
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
changed the title
…odecov/gazebo into rvinnakota/refactor-repo-table
|
Before diving too deep into reviewing this PR, after playing around with it, when sorting it doesn't seem to update the query to the API so we're not sorting on the entire repository list that a given org has only the ones present in the table at a given time. Can you refactor the Here's an example for some greater detail as to what is required here. |
…ota/refactor-repo-table
|
Visit https://preview-pr-2518.codecov.dev for your PR preview. Expires after 1 month automatically. |
…ota/refactor-repo-table
…ota/refactor-repo-table
rohitvinnakota-codecov
force-pushed
the
rvinnakota/refactor-repo-table
branch
from
59a44d7 to
47aafdf
Compare
rohitvinnakota-codecov
force-pushed
the
rvinnakota/refactor-repo-table
branch
from
ea5f4f5 to
ca7bc6f
Compare
…ota/refactor-repo-table
rohitvinnakota-codecov
force-pushed
the
rvinnakota/refactor-repo-table
branch
from
b379e8e to
0049dea
Compare
Description
Updates the
ReposTablecomponent to use tanstack. This table is rendered on the owner page and the analytics page. This PR also includes typescript conversions toReposTableas well asuseRepos. This closes codecov/engineering-team#583.Screenshots
Screen.Recording.2024-01-17.at.4.33.24.PM.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.