[keycloakx/keycloak 25/26] Adds internal management port to service temp… #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilian-krauss
changed the title
…late Signed-off-by: Maximilian Krauß <[email protected]>
maximilian-krauss
force-pushed
the
fix/add-internal-service-port
branch
from
0eec3c2 to
43420b1
Compare
|
Hi @stefangries, how's the chance to get this one merged into one of the next releases? 🙂 Or is something mising? Cheers, |
|
Hi @maximilian-krauss, we are currently working on reorganising ourselves internally to better maintain the chart. This should be done soon and then we will be able to process the pull requests again. |
|
I see, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the management port to the list of ports in the service template. Its needed in order for the Prometheus Operator to gather metrics.
Closes #796
Its based on PR #798 which was closed due to inactivity. Credits to @Tim-Schwalbe for providing the PR in the first place 🙂