Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Switching from banner to presentation #401

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

MichaelCherry
Copy link
Collaborator

@MichaelCherry MichaelCherry commented Jun 27, 2019

Description

Changing image role from banner to presentation.
Based on a few resources:

  • role=presentation is supported in all major browsers, JAWS, NVDA, and IE 11
  • role=none is supported by JAWS and most major browsers (but not NVDA or IE 11)
  • Narrator in Windows supports none of the above.

Resources:
https://codepen.io/stevef/post/none-or-presentation
w3c/aria-practices#515

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshot

image

Testing

Look at the image role in the dev tools

Checklist

Applicable for all code changes.

- [ ] I have commented my code, particularly in hard-to-understand areas

  • My changes generate no new compiler warnings
  • My changes generate no new accessibility errors and/or warnings
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have researched WCAG2.1 accessibility standards and met them in this PR (can be navigated using a keyboard)
  • My changes look good on IE 11+ and Chrome

@MichaelCherry MichaelCherry merged commit c9086f9 into master Jun 27, 2019
@MichaelCherry MichaelCherry deleted the img-role-change branch June 27, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants