*: refactors for value separation #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value length is encoded as a uint32, but the ValueFetcher's Fetch method expected a signed int32.
|
This change is |
jbowens
changed the title
Clarify the naming around value prefixes and value handles for existing value blocks, so they're not confusing with the introduction of value handles pointing into blob files.
Factor out logic to decode a block handle from a value block index into a helper, DecodeBlockHandleFromIndex. Today this is only used internally within the valblk package. Future work will call DecodeBlockHandleFromIndex when looking up blocks within external blob files.
RaduBerinde
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 14 files reviewed, all discussions resolved
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value length is encoded as a uint32, but the ValueFetcher's Fetch method expected a signed int32.