*: Don't block flushes on cleaning turns #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
approved these changes
May 3, 2021
There was a problem hiding this comment.
Is this something we can add a test for? I'm imagining a test where we grab the cleaning turn, run a flush/ingest while the turn is held and verify it completes.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @jbowens)
A flush isn't marked as complete (and flushing set to false) until deleteObsoleteFiles returns. Currently, deleteObsoleteFiles waits for other cleaning turns to complete before doing its own cleaning. This could make flushes wait for cleanup after large compactions, causing write stalls. This change makes flushes move along and mark themselves as completed if a cleaner job is already running, instead of waiting for them. This allows for a lower impact on user-observed write latency.
itsbilal
force-pushed
the
flush-dont-wait-cleaners
branch
from
48a0e53 to
6f7a8c3
Compare
itsbilal
commented
May 3, 2021
There was a problem hiding this comment.
Added a test! Basically does just that - grabs a cleaning turn then does a flush.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @jbowens)
petermattis
approved these changes
May 3, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @jbowens)
|
TFTR! |
This was referenced May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flush isn't marked as complete (and flushing set to
false) until deleteObsoleteFiles returns. Currently,
deleteObsoleteFiles waits for other cleaning turns to complete
before doing its own cleaning. This could make flushes wait
for cleanup after large compactions, causing write stalls.
This change makes flushes move along and mark themselves as
completed if a cleaner job is already running, instead of waiting
for them. This allows for a lower impact on user-observed
write latency.