Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: add Excise API #4286

Closed
jbowens opened this issue Jan 24, 2025 · 0 comments · Fixed by #4361
Closed

db: add Excise API #4286

jbowens opened this issue Jan 24, 2025 · 0 comments · Fixed by #4361

Comments

@jbowens
Copy link
Collaborator

jbowens commented Jan 24, 2025

Add a new API that allows excising a span of the database without performing an accompanying ingestion. This is useful for recovering from an instance where externally linked sstables no longer exist or are corrupt.

Jira issue: PEBBLE-329

@RaduBerinde RaduBerinde self-assigned this Jan 24, 2025
@jbowens jbowens assigned jbowens and unassigned RaduBerinde Mar 4, 2025
jbowens added a commit to jbowens/pebble that referenced this issue Mar 4, 2025
Add an Excise method to the DB allowing an excise without an accompanying
ingestion. This will be used in CockroachDB to recover from corruption by
excising out corrupted sstables.

For now, this implementation uses DB.ingest. I think a future refactor should
be able to clean these code paths up and potentially refactor excise to be
independent of the ingest codepath. Today, it's necessary to reuse the logic to
perform excises as 'flushable ingests.'

Closes cockroachdb#4286.
jbowens added a commit to jbowens/pebble that referenced this issue Mar 4, 2025
Add an Excise method to the DB allowing an excise without an accompanying
ingestion. This will be used in CockroachDB to recover from corruption by
excising out corrupted sstables.

For now, this implementation uses DB.ingest. I think a future refactor should
be able to clean these code paths up and potentially refactor excise to be
independent of the ingest codepath. Today, it's necessary to reuse the logic to
perform excises as 'flushable ingests.'

Closes cockroachdb#4286.
jbowens added a commit to jbowens/pebble that referenced this issue Mar 4, 2025
Add an Excise method to the DB allowing an excise without an accompanying
ingestion. This will be used in CockroachDB to recover from corruption by
excising out corrupted sstables.

For now, this implementation uses DB.ingest. I think a future refactor should
be able to clean these code paths up and potentially refactor excise to be
independent of the ingest codepath. Today, it's necessary to reuse the logic to
perform excises as 'flushable ingests.'

Closes cockroachdb#4286.
jbowens added a commit to jbowens/pebble that referenced this issue Mar 5, 2025
Add an Excise method to the DB allowing an excise without an accompanying
ingestion. This will be used in CockroachDB to recover from corruption by
excising out corrupted sstables.

For now, this implementation uses DB.ingest. I think a future refactor should
be able to clean these code paths up and potentially refactor excise to be
independent of the ingest codepath. Today, it's necessary to reuse the logic to
perform excises as 'flushable ingests.'

Closes cockroachdb#4286.
jbowens added a commit that referenced this issue Mar 5, 2025
Add an Excise method to the DB allowing an excise without an accompanying
ingestion. This will be used in CockroachDB to recover from corruption by
excising out corrupted sstables.

For now, this implementation uses DB.ingest. I think a future refactor should
be able to clean these code paths up and potentially refactor excise to be
independent of the ingest codepath. Today, it's necessary to reuse the logic to
perform excises as 'flushable ingests.'

Closes #4286.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants