Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\demo_node docs #6646

Merged
merged 1 commit into from
Feb 27, 2020
Merged

\demo_node docs #6646

merged 1 commit into from
Feb 27, 2020

Conversation

ericharmeling
Copy link
Contributor

Fixes #6070.

Added syntax table and examples for cockroach demo cluster SQL \demo_node commands.

@ericharmeling ericharmeling requested a review from otan February 20, 2020 18:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor

otan commented Feb 25, 2020


v20.1/cockroach-demo.md, line 257 at r1 (raw file):

### Shut down and restart nodes

If you start a demo cluster with multiple nodes, you can use the [`\demo_node`](cockroach-demo.html#shutting-down-and-restarting-nodes) to shut down and restart individual nodes in the demo cluster.

can you add a note this is currently experimental?
(we haven't documented it on the cli yet for this reason :))

@ericharmeling ericharmeling force-pushed the cockroach-demo-kill-restart branch from 2d64ad3 to b104e04 Compare February 26, 2020 19:01
Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR @otan. I added the experimental warning to the docs.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @otan)


v20.1/cockroach-demo.md, line 257 at r1 (raw file):

Previously, otan (Oliver Tan) wrote…

can you add a note this is currently experimental?
(we haven't documented it on the cli yet for this reason :))

Done.

@Amruta-Ranade Amruta-Ranade mentioned this pull request Feb 26, 2020
6 tasks
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ericharmeling ericharmeling merged commit 6e762f4 into master Feb 27, 2020
@ericharmeling ericharmeling deleted the cockroach-demo-kill-restart branch February 27, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NH] Improve Cockroach Demo
4 participants