Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Map: Related changes #2808

Merged
merged 6 commits into from
Mar 29, 2018
Merged

Node Map: Related changes #2808

merged 6 commits into from
Mar 29, 2018

Conversation

Amruta-Ranade
Copy link
Contributor

@jseldess I opened this separate PR for the structural changes related to the Node Map. (Not many content changes from v1.1)

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Amruta-Ranade. See my comments/questions.

You're going to update the other ui pages with relevant navigation changes when you clean up the screenshots? For example, the intro on admin-ui-overview-dashboard.md` is currently:

On accessing the CockroachDB Admin UI, the Overview is shown by default.

{{site.data.alerts.end}}

#### Change time range
<img src="{{ 'images/admin_ui_overview.gif' | relative_url }}" alt="CockroachDB Admin UI" style="border:1px solid #eee;max-width:100%" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist. What image are you trying to include here? Btw, you can see this breakage in the test version of the page on s3. Be sure to always check the rendered pages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second glance, I think you just need to include the version directory, i.e., images/v2.0/...


### Summary Panel
<img src="{{ 'images/v2.0/admin_ui_summary_panel.png' | relative_url }}" alt="CockroachDB Admin UI Summary Panel" style="border:1px solid #eee;max-width:40%" />
<img src="{{ 'images/admin_ui_summary_panel.png' | relative_url }}" alt="CockroachDB Admin UI Summary Panel" style="border:1px solid #eee;max-width:40%" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Image doesn't exist.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second glance, I think you just need to include the version directory, i.e., images/v2.0/...


<img src="{{ 'images/v2.0/admin-ui-node-components.png' | relative_url }}" alt="CockroachDB Admin UI Summary Panel" style="border:1px solid #eee;max-width:90%" />

**Region component**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list region before node, if that's the hierarchy from a user's perspective?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node has the individual metrics that are then aggregated to the region level. Hence the hierarchy in the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but my question is about UX: Should we list these in the order that users will encounter them? They won't see nodes until they drill into regions, right? If so, I'd list regions first.

@@ -107,6 +84,58 @@ Down Since | How long the node has been down.

When you decommission a node, CockroachDB lets the node finish in-flight requests, rejects any new requests, and transfers all range replicas and range leases off the node so that it can be safely shut down. See [Remove Nodes](remove-nodes.html) for more information.

### Node Map (Enterprise)

The **Node Map** is an [enterprise-only](enterprise-licensing.html) feature that gives you a visual representation of the geographical configuration of your cluster. To set up and enable the Node Map, see [Enable Node Map](enable-node-map.html). The Node Map consists of the following components:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd cut out the second sentence and move it after the component sections, with some edits:

For guidance on enabling and using the node map, see ...

{{site.data.alerts.end}}
Capacity Usage | <ul><li>The storage capacity used as a percentage of total storage capacity allocated across all nodes.</li><li>The current capacity usage.</li></ul>
Node Status | <ul><li>The number of [live nodes](admin-ui-access-and-navigate.html#live-nodes) in the cluster.</li><li>The number of suspect nodes in the cluster. A node is considered a suspect node if it's liveness status is unavailable or the node is in the process of decommissioning.</li><li>The number of [dead nodes](admin-ui-access-and-navigate.html#dead-nodes) in the cluster.</li>
Replication Status | <ul><li>The total number of ranges in the cluster.</li><li>The number of [under-replicated ranges](admin-ui-replication-dashboard.html#review-of-cockroachdb-terminology) in the cluster. A non-zero number indicates an unstable cluster.</li><li>The number of [unavailable ranges](admin-ui-replication-dashboard.html#review-of-cockroachdb-terminology) in the cluster. A non-zero number indicates an unstable cluster.</li>

### Nodes List
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update this to reference the Node List on the ui landing page rather than reference the more deeply buried version of the Node List?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh..excellent catch. The Node List is the default view on the Overview page now, need to specify that. Thanks!


<img src="{{ 'images/v2.0/admin-ui-region-component.png' | relative_url }}" alt="CockroachDB Admin UI Summary Panel" style="border:1px solid #eee;max-width:90%" />

### Time Series Graphs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, the Summary panel, and the Events panel, don't we need to tell users how to get to these areas now that they're not available from the main ui landing page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...yes..for the Time Series as well. Adding the navigation now.

@jseldess
Copy link
Contributor

Also looks like there are some links to fix:

[17:41:18][Step 1/1] 13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/v2.0/admin-ui-access-and-navigate.html
[17:41:18][Step 1/1]   target does not exist --- 13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/v2.0/admin-ui-access-and-navigate.html --> admin-ui-access-and-navigate.htmll#events-panel
[17:41:18][Step 1/1]   target does not exist --- 13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/v2.0/admin-ui-access-and-navigate.html --> /13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/images/admin_ui_overview.gif
[17:41:18][Step 1/1]   target does not exist --- 13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/v2.0/admin-ui-access-and-navigate.html --> /13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/images/admin_ui_summary_panel.png
[17:41:18][Step 1/1] 13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/v2.0/admin-ui-overview.html
[17:41:18][Step 1/1]   target does not exist --- 13ca5e1dd51f7156ef6f159f5ec9f768e411d5b1/v2.0/admin-ui-overview.html --> admin-ui-node-map.html

@Amruta-Ranade
Copy link
Contributor Author

Amruta-Ranade commented Mar 28, 2018

@jseldess About images and navigation changes, I am planning to open a separate PR just for the bulk changes (screenshots, navigation, links). Wanted to get the content/structural changes done to get them reviewed.

@Amruta-Ranade
Copy link
Contributor Author

@jseldess Fixed the links and images

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit. Also, the new image for the Node List is nice in that it shows all 3 sections, but it represents an unhealthy cluster; any cluster with only 2 live nodes is under-replicated. Any chance you could get an image showing all 3 sections, but where there are at least 3 healthy live nodes?

-----------|------------
Cluster Overview | <ul><li>[Cluster Overview panel](admin-ui-access-and-navigate.html#cluster-overview-panel)</li><li>[Node List](admin-ui-access-and-navigate.html#node-list). [Enterprise users](enterprise-licensing.html) can enable and switch to the [Node Map](admin-ui-access-and-navigate.html#node-map-enterprise) view. </li></ul>
Cluster Metrics | <ul><li>[Time Series graphs](admin-ui-access-and-navigate.html#time-series-graphs)</li><li>[Summary Panel](admin-ui-access-and-navigate.html#summary-panel)</li><li>[Events List](admin-ui-access-and-navigate.html#events-panel)</li></ul>
Databases | Information about the Tables or Grants in your [databases](admin-ui-databases-page.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use lowercase for tables and grants. Also probably want to change or to and.

@Amruta-Ranade
Copy link
Contributor Author

@jseldess Done.

@jseldess
Copy link
Contributor

Thanks, @Amruta-Ranade!

@Amruta-Ranade Amruta-Ranade merged commit 8d92906 into master Mar 29, 2018
@Amruta-Ranade Amruta-Ranade deleted the admin_ui_changes branch March 29, 2018 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants