Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud/gcp_test: add weird code 0/ok error to regex #98732

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

dt
Copy link
Member

@dt dt commented Mar 15, 2023

Still unsure why we sometimes see this instead of the other more infromative errors but in the meanime, make the test pass.

Release note: none.
Epic: none.

@dt dt requested review from benbardin and adityamaru March 15, 2023 23:56
@dt dt requested a review from a team as a code owner March 15, 2023 23:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in commit message: s/meanime/meantime/

Thanks for tracking this down. If you are force pushing to fix the commit message, I suppose you could add a comment linking to the other issue you filed about why in the world we get "code 0/OK"

This is some PROgramming.

Still unsure why we sometimes see this instead of the other more informative
errors but in the meantime, make the test pass.

Release note: none.
Epic: none.
@dt
Copy link
Member Author

dt commented Mar 16, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 16, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 16, 2023

Build succeeded:

@craig craig bot merged commit 898a32a into cockroachdb:master Mar 16, 2023
@dt dt deleted the code0 branch March 16, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants