Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: change conn close error to warning #98600

Merged

Conversation

dhartunian
Copy link
Collaborator

Resolves: #98523
Epic: None
Release note: None

Resolves: cockroachdb#98523
Epic: None
Release note: None
@dhartunian dhartunian requested a review from a team March 14, 2023 17:45
@dhartunian dhartunian requested a review from a team as a code owner March 14, 2023 17:45
@blathers-crl
Copy link

blathers-crl bot commented Mar 14, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@dhartunian dhartunian requested a review from knz March 14, 2023 17:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dhartunian
Copy link
Collaborator Author

bors r=knz,abarganier

@craig
Copy link
Contributor

craig bot commented Mar 14, 2023

Build succeeded:

@dhartunian
Copy link
Collaborator Author

blathers backport 22.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server: use of closed network connection when quiescing
4 participants