kvserver: deflake learner joint cfg relocate range #98536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvoli
force-pushed
the
230313.learnerjointconf
branch
from
3dc04f9 to
d0ae2a6
Compare
|
This change is |
kvoli
changed the title
Previously, in `TestLearnerOrJointConfigAdminRelocateRange` it was
possible for there to be an in-flight snapshot towards a learner, prior
to sending `AdminRelocateRange` command. When this occurred, the test
would fail as `AdminRelocateRange` returns an error when finding any
in-flight snapshots to learners. This situation occurred infrequently,
causing the test to flake.
This commit updates the `TestLearnerOrJointConfigAdminRelocateRange`
test to first assert that there are the expected number of learners,
then assert that there are no in-flight snapshots towards learners
before beginning the main testing logic. The test is now unskipped.
```
dev test pkg/kv/kvserver \
-f TestLearnerOrJointConfigAdminRelocateRange \
-v --stress
...
5652 runs so far, 0 failures, over 12m30s
```
Resolves: cockroachdb#95500
Release note: None
kvoli
force-pushed
the
230313.learnerjointconf
branch
from
d0ae2a6 to
0a62474
Compare
|
bors r=andrewbaptist |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in
TestLearnerOrJointConfigAdminRelocateRangeit was possible for there to be an in-flight snapshot towards a learner, prior to sendingAdminRelocateRangecommand. When this occurred, the test would fail asAdminRelocateRangereturns an error when finding any in-flight snapshots to learners. This situation occurred infrequently, causing the test to flake.This commit updates the
TestLearnerOrJointConfigAdminRelocateRangetest to first assert that there are the expected number of learners, then assert that there are no in-flight snapshots towards learners before beginning the main testing logic. The test is now unskipped.Resolves: #95500
Release note: None