-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: sql: add metrics for prepared statement memory usage #97741
Conversation
Add node-level metrics for memory used by prepared statements across all sessions. Assists: cockroachdb#72581 Epic: None Release note (ui change): Add the following new metrics to track memory usage of prepared statements in sessions: - sql.mem.internal.session.prepared.current - sql.mem.internal.session.prepared.max-avg - sql.mem.internal.session.prepared.max-count - sql.mem.internal.session.prepared.max-max - sql.mem.internal.session.prepared.max-p50 - sql.mem.internal.session.prepared.max-p75 - sql.mem.internal.session.prepared.max-p90 - sql.mem.internal.session.prepared.max-p99 - sql.mem.internal.session.prepared.max-p99.9 - sql.mem.internal.session.prepared.max-p99.99 - sql.mem.internal.session.prepared.max-p99.999 - sql.mem.sql.session.prepared.current - sql.mem.sql.session.prepared.max-avg - sql.mem.sql.session.prepared.max-count - sql.mem.sql.session.prepared.max-max - sql.mem.sql.session.prepared.max-p50 - sql.mem.sql.session.prepared.max-p75 - sql.mem.sql.session.prepared.max-p90 - sql.mem.sql.session.prepared.max-p99 - sql.mem.sql.session.prepared.max-p99.9 - sql.mem.sql.session.prepared.max-p99.99 - sql.mem.sql.session.prepared.max-p99.999
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @rharding6373)
Failure looks unrelated so I'll go ahead and merge. |
Backport 1/1 commits from #97590.
/cc @cockroachdb/release
Add node-level metrics for memory used by prepared statements across all sessions.
Assists: #72581
Epic: None
Release note (ui change): Add the following new metrics to track memory usage of prepared statements in sessions:
Release justification: small change to metrics to improve observability.