raftlog: don't embed raftpb.Entry in Entry #97349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
`raftpb.Entry` is a `fmt.Stringer`, so by embedding it we were making the string representation of structs embedding it worse. Concretely, in cockroachdb#97173 I noticed that `*replicatedCmd` ended up just printing the `raftpb.Entry` that it wrapped, which was not helpful. Epic: none Release note: None
tbg
force-pushed
the
avoid-stringer-embedding
branch
from
f5069e2 to
23dfb1a
Compare
|
@pavelkalinnikov this one is kind of, meh, I don't love the idea of a separate type here, but I think that blindly embedding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raftpb.Entryis afmt.Stringer, so by embedding it we were makingthe string representation of structs embedding it worse.
Concretely, in #97173 I noticed that
*replicatedCmdended up justprinting the
raftpb.Entrythat it wrapped, which was not helpful.Epic: none
Release note: None