Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: gceworker: don't anchor absolute paths at repo in get #97177

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

tbg
Copy link
Member

@tbg tbg commented Feb 15, 2023

Now one may ./scripts/gceworker.ssh get /home/foo bar.
Previously it would try to copy from
go/src/github.com/cockroachdb/cockroach/home/foo/bar.

Epic: none
Release note: None

@tbg tbg requested a review from erikgrinaker February 15, 2023 14:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Now one may `./scripts/gceworker.ssh get /home/foo bar`.
Previously it would try to copy from
`go/src/github.com/cockroachdb/cockroach/home/foo/bar`.

Epic: none
Release note: None
@tbg tbg force-pushed the gceworker-get-abs branch from 14b36f4 to 22762a7 Compare February 20, 2023 07:15
@tbg
Copy link
Member Author

tbg commented Feb 20, 2023

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Feb 20, 2023

Build succeeded:

@craig craig bot merged commit 03b3159 into cockroachdb:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants