storage: check for old store version upfront #96394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
thanks for doing this!
Reviewed 3 of 3 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)
Removing this unused method from the Engine interface. Release note: None
This change adds a check for old versions as soon as we open the min version file, before opening the store. We currently check this at a later time; in some cases, it is too late and there is potential for corruption. Release note: None Fixes cockroachdb#89836
RaduBerinde
force-pushed
the
min-ver-check-upfront
branch
from
d52e7bf to
39c7443
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage: minor cleanup around MinVersionIsAtLeastTargetVersion
Removing this unused method from the Engine interface.
Release note: None
storage: check for old store version upfront
This change adds a check for old versions as soon as we open the min
version file, before opening the store. We currently check this at a
later time; in some cases, it is too late and there is potential for
corruption.
Release note: None
Fixes #89836